Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoD Project PR review workflow #1045

Open
lijiarui opened this issue Jul 10, 2021 · 0 comments
Open

GSoD Project PR review workflow #1045

lijiarui opened this issue Jul 10, 2021 · 0 comments

Comments

@lijiarui
Copy link
Member

lijiarui commented Jul 10, 2021

hi GSoD tech writers!

Thanks for contributing so much to Wechaty Community, you all create so much fantastic PR. And thanks for @proudofsimin @Rohitesh-Kumar-Jain coordination.

I received @proudofsimin feedback, and I suggest the volunteer team can file an issue like this: #1026 and assign this issue to me to track the high priority PR. I would fill in the blank to synchronize PR review progress. And I suggest our GSoD team follow our PR reviewing and approving rules as follows:

PR Reviewing & Approving Workflow:

For writers:

Writers who are in the same team are REQUIRED to review each other’s PR, and give “Request changes” or “Approve”
Writers are encouraged to give “Request changes”, “Approve”, or “Comment” to any PRs. (please contribute to the whole team by doing it!)

For volunteers:

Volunteers are REQUIRED to review all PRs created by writers and give “Request changes” or “Approve”

Mentors are in charge of reviewing the PR after:

  • Volunteers create an issue list about the high priority PR
  • PR passed all the CI tests (CLA & unit testings)
  • PR gets approved by all the project team members (if applicable, 0-1 approval)
  • PR gets approved by all volunteers (2 approvals)
@lijiarui lijiarui pinned this issue Jul 10, 2021
@lijiarui lijiarui changed the title GSoD Project PR review rules GSoD Project PR review Jul 12, 2021
@lijiarui lijiarui changed the title GSoD Project PR review GSoD Project PR review workflow Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant