-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoD Project PR review workflow #1045
Labels
Comments
This was referenced Jul 10, 2021
Closed
Closed
Merged
Merged
Closed
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi GSoD tech writers!
Thanks for contributing so much to Wechaty Community, you all create so much fantastic PR. And thanks for @proudofsimin @Rohitesh-Kumar-Jain coordination.
I received @proudofsimin feedback, and I suggest the volunteer team can file an issue like this: #1026 and assign this issue to me to track the high priority PR. I would fill in the blank to synchronize PR review progress. And I suggest our GSoD team follow our PR reviewing and approving rules as follows:
PR Reviewing & Approving Workflow:
For writers:
Writers who are in the same team are REQUIRED to review each other’s PR, and give “Request changes” or “Approve”
Writers are encouraged to give “Request changes”, “Approve”, or “Comment” to any PRs. (please contribute to the whole team by doing it!)
For volunteers:
Volunteers are REQUIRED to review all PRs created by writers and give “Request changes” or “Approve”
Mentors are in charge of reviewing the PR after:
The text was updated successfully, but these errors were encountered: