Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main concepts in Wechaty #904

Merged
merged 18 commits into from
Aug 2, 2021
Merged

Main concepts in Wechaty #904

merged 18 commits into from
Aug 2, 2021

Conversation

nibble0101
Copy link
Contributor

Improve the Introduction and Explanation sections project

Section Sub-section Technical Writer
Introduction Main concepts in Wechaty Chris Estepa, Joseph Mawa

This is Main concepts in Wechaty sub-section of the Introduction section

image
image
image

@nibble0101 nibble0101 requested review from a team as code owners May 28, 2021 14:58
@nibble0101 nibble0101 mentioned this pull request May 28, 2021
Open
@nibble0101 nibble0101 added introduction Pull requests that update introduction section of the documentation GSoD 2021 labels May 28, 2021
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nibble0101 and @chris-4444, I approve these changes.

proudofsimin
proudofsimin reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually feel the word terminology or glossary might be better than "concepts". How do you think?

docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
proudofsimin
proudofsimin approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@lijiarui
Copy link
Member

hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@proudofsimin
Copy link
Contributor

hi @Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in #1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

Hi @chris-4444, Could you review and add the tag ready to merge afterwards? Thank you.

@Rohitesh-Kumar-Jain
Copy link
Contributor

@chris-4444 I would like you to once go through the PR, and approve when you think it's ready to get merged.

@lijiarui
Copy link
Member

@chris-4444 I would like you to once go through the PR, and approve when you think it's ready to get merged.

Hi @chris-4444 , as @Rohitesh-Kumar-Jain said, I will remove the ready to merge tag, after it got enough approval, feel free to add it again.

chris-4444
chris-4444 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@chris-4444 chris-4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain mentioned this pull request Jul 14, 2021
Closed
lijiarui
lijiarui requested changes Jul 14, 2021
View reviewed changes
docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
docusaurus/docs/main-concepts-in-wechaty.md Show resolved Hide resolved
docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
docusaurus/docs/main-concepts-in-wechaty.md Show resolved Hide resolved
docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
@nibble0101 nibble0101 mentioned this pull request Jul 15, 2021
Open
@lijiarui lijiarui mentioned this pull request Jul 18, 2021
Merged
@nibble0101 nibble0101 requested a review from lijiarui July 21, 2021 11:40
lijiarui
lijiarui requested changes Jul 29, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more tips then I will merge this PR!

docusaurus/docs/main-concepts-in-wechaty.md Outdated Show resolved Hide resolved
@nibble0101 nibble0101 requested a review from lijiarui July 30, 2021 16:43
lijiarui
lijiarui approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain merged commit 0c7a560 into wechaty:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4444 chris-4444 chris-4444 approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@lijiarui lijiarui lijiarui approved these changes

Assignees

@nibble0101 nibble0101

@chris-4444 chris-4444

Labels
GSoD 2021 introduction Pull requests that update introduction section of the documentation ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nibble0101 @lijiarui @proudofsimin @Rohitesh-Kumar-Jain @chris-4444