Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated team proposal for How to Guide #869

Merged
merged 13 commits into from
Sep 8, 2021
Merged

Conversation

abhishek-iiit
Copy link
Member

  • Updated Project Section due to the case of overlapping of the topics with the tutorials :)

@abhishek-iiit abhishek-iiit requested a review from a team as a code owner May 19, 2021 10:25
@Rohitesh-Kumar-Jain
Copy link
Contributor

@proudofsimin

@proudofsimin
Copy link
Contributor

@abhishek-iiit
Thank you for your effort. I actually suggest you could simply remove the "About bot" section. Background information is more or less within the scope of explanation. If you feel necessary to have this section, how about combine it with the overview section? I like how you are very considerate to your users, but "about bot" is probably not something your users will learn "how to" do things.

@abhishek-iiit
Copy link
Member Author

@proudofsimin Thank you soo much for the feedback :)

@abhishek-iiit
Copy link
Member Author

Added

  • Deploy with Heroku
  • Deploy with Docker
  • FAQ section

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflict in this PR before we can continue reviewing it.

@abhishek-iiit
Copy link
Member Author

Resolved the conflicting file.
Thanks, @huan for addressing this, will take care from next time :)

Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for document content.

Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @huan I believe the PR is ready to get merged.

@lijiarui
Copy link
Member

@Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@proudofsimin
Copy link
Contributor

@Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in #1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@vasvi-sood Wechaty committee requested each writer in the same team to review each other's document. Could you sign it off? Thank you.

@vasvi-sood
Copy link
Contributor

@Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in #1045
This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@vasvi-sood Wechaty committee requested each writer in the same team to review each other's document. Could you sign it off? Thank you.

Ohkay sure, I'll do that

@abhishek-iiit abhishek-iiit requested a review from huan July 29, 2021 17:44
@Rohitesh-Kumar-Jain
Copy link
Contributor

@vasvi-sood pls review this

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please read and follow #1257, and feel free to help yourself to merge it by following the merge workflow.

Thank you very much!

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain merged commit 4ee30e5 into master Sep 8, 2021
@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain deleted the team_proposal branch September 8, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants