-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated team proposal for How to Guide #869
Conversation
abhishek-iiit
commented
May 19, 2021
- Updated Project Section due to the case of overlapping of the topics with the tutorials :)
@abhishek-iiit |
@proudofsimin Thank you soo much for the feedback :) |
Added
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflict in this PR before we can continue reviewing it.
Resolved the conflicting file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for document content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @huan I believe the PR is ready to get merged.
@Rohitesh-Kumar-Jain As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045 This PR should follow our rules and get enough approval, then I will review this PR. So I remove the |
@vasvi-sood Wechaty committee requested each writer in the same team to review each other's document. Could you sign it off? Thank you. |
Ohkay sure, I'll do that |
@vasvi-sood pls review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please read and follow #1257, and feel free to help yourself to merge it by following the merge workflow.
Thank you very much!