Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left Navigation Menu #946

Closed
wants to merge 6 commits into from
Closed

Left Navigation Menu #946

wants to merge 6 commits into from

Conversation

abhishek-iiit
Copy link
Member

@abhishek-iiit abhishek-iiit commented Jun 16, 2021 •
edited
Loading

Redefined left-sidebar

Screenshot from 2021-07-24 16-36-14

@abhishek-iiit abhishek-iiit added GSoD 2021 how to guide PR related to How-to-Guide section labels Jun 16, 2021
@abhishek-iiit abhishek-iiit requested review from a team as code owners June 16, 2021 05:44
@abhishek-iiit abhishek-iiit linked an issue Jun 16, 2021 that may be closed by this pull request
Update and enhance how-to-guide section #896
Closed
21 tasks
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect PR, very good

proudofsimin
proudofsimin approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lijiarui
Copy link
Member

Please resolve the conflict since some of the PR has been merged.

@lijiarui
Copy link
Member

Hi @abhishek-iiit As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@Rohitesh-Kumar-Jain
Copy link
Contributor

Rohitesh-Kumar-Jain commented Jul 12, 2021 •
edited
Loading

@vasvi-sood We would be glad if you may once go through the PR, and either request for changes or approve the PR.

edit: sorry I tagged the wrong person 😅

vasvi-sood
vasvi-sood approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@vasvi-sood vasvi-sood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain mentioned this pull request Jul 18, 2021
Closed
lijiarui
lijiarui requested changes Jul 18, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe we should change all of the md file to mdx in the doc.

And please resolve the conflict first.

@abhishek-iiit abhishek-iiit mentioned this pull request Jul 25, 2021
Merged
@abhishek-iiit
Copy link
Member Author

Closing this PR due to some extra added files into this PR. Shifted to PR #1139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijiarui lijiarui lijiarui requested changes

@vasvi-sood vasvi-sood vasvi-sood approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@huan huan Awaiting requested review from huan

Assignees

@abhishek-iiit abhishek-iiit

@vasvi-sood vasvi-sood

Labels
GSoD 2021 how to guide PR related to How-to-Guide section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update and enhance how-to-guide section
5 participants
@abhishek-iiit @lijiarui @Rohitesh-Kumar-Jain @proudofsimin @vasvi-sood