Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week-5 Updated the Wechaty Puppet Service #965

Merged
merged 17 commits into from
Sep 11, 2021
Merged

Week-5 Updated the Wechaty Puppet Service #965

merged 17 commits into from
Sep 11, 2021

Conversation

shraddhavp
Copy link
Contributor

this PR links #890

@shraddhavp shraddhavp requested a review from a team as a code owner June 20, 2021 12:34
@shraddhavp
Copy link
Contributor Author

@proudofsimin and @Rohitesh-Kumar-Jain please have look at the PR and please do let me know your feedback

@proudofsimin
Copy link
Contributor

Can you provide the screenshot? I saw you made quite a lot of changes so it's a bit hard to preview. Thank you.

@shraddhavp
Copy link
Contributor Author

Can you provide the screenshot? I saw you made quite a lot of changes so it's a bit hard to preview. Thank you.

yes will do so

@shraddhavp
Copy link
Contributor Author

@proudofsimin please have a look at the screenshots added

@shraddhavp
Copy link
Contributor Author

Screenshot (4)
Screenshot (3)
Screenshot (2)

@shraddhavp shraddhavp changed the title Updated the Wechaty Puppet Service Week-5 Updated the Wechaty Puppet Service Jun 24, 2021
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 27, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proofread

proudofsimin
proudofsimin approved these changes Jun 27, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see you really improve a lot!! You are so great! You did very great in the first part and with only some minor improvement in the second part, so I still approve it. Thank you.

docusaurus/docs/specs/service.md Show resolved Hide resolved
docusaurus/docs/specs/service.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/service.md Show resolved Hide resolved
@shraddhavp shraddhavp requested review from huan and a team July 6, 2021 03:53
@lijiarui
Copy link
Member

Hi @shraddhavp As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@shraddhavp
Copy link
Contributor Author

Hi @shraddhavp As GSoD Project PR Review Rules in #1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

yes @lijiarui mam sure,thanks

@Rohitesh-Kumar-Jain
Copy link
Contributor

@Soumi7 We would be glad if you may once go through the PR, and either request for changes or approve the PR.

Soumi7
Soumi7 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@Soumi7 Soumi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shraddhavp shraddhavp mentioned this pull request Jul 18, 2021
Closed
huan
huan requested changes Sep 7, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow my reviews, thank you very much!

docusaurus/docs/specs/service.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/service.md Show resolved Hide resolved
docusaurus/docs/specs/service.md Outdated Show resolved Hide resolved
huan
huan approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following my reviews, appreciate the improvements!

lijiarui
lijiarui approved these changes Sep 11, 2021
View reviewed changes
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shraddhavp shraddhavp merged commit 32442f3 into master Sep 11, 2021
@shraddhavp shraddhavp deleted the shraddhavp-patch-3 branch September 11, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@Soumi7 Soumi7 Soumi7 approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

@lijiarui lijiarui lijiarui approved these changes

@huan huan huan approved these changes

Assignees
No one assigned
Labels
GSoD 2021 ready to merge references
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shraddhavp @proudofsimin @lijiarui @Rohitesh-Kumar-Jain @huan @Soumi7