Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Wechaty token section #919

Merged
merged 12 commits into from
Sep 8, 2021
Merged

Added Wechaty token section #919

merged 12 commits into from
Sep 8, 2021

Conversation

shraddhavp
Copy link
Contributor

This PR is for the Wechaty token section, this links #890

@shraddhavp shraddhavp requested a review from a team as a code owner June 3, 2021 13:31
@shraddhavp shraddhavp requested a review from a team June 3, 2021 13:32
@shraddhavp
Copy link
Contributor Author

@huan @Rohitesh-Kumar-Jain and @proudofsimin please check out the PR

proudofsimin
proudofsimin requested changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm feeling like you've gone too far in this part. Hold on, and don't give instructions in reference. The most important things in reference are easy to search and include the information as much as possible, so the word like "example" should not appear as you are supposed to provide everything like an encyclopedia. I found a good example for your reference. I think you may consider reconstruct this part a little bit. Please let me know if you have any question.

docusaurus/docs/specs/specs-token.md Outdated

## What is Wechaty Puppet Service Token Gateway?

Wechaty Puppet Service Token Gateway is a gateway for converting the Wechaty Puppet Provider to a Wechaty Puppet Service.This can be done by setting up different environment variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space between two sentences and a period at the end of the second sentence.

docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
@shraddhavp
Copy link
Contributor Author

I'm feeling like you've gone too far in this part. Hold on, and don't give instructions in reference. The most important things in reference are easy to search and include the information as much as possible, so the word like "example" should not appear as you are supposed to provide everything like an encyclopedia. I found a good example for your reference. I think you may consider reconstruct this part a little bit. Please let me know if you have any question.

ok will do the changes @proudofsimin ,thanks

@shraddhavp
Copy link
Contributor Author

@proudofsimin have done the changes please check now,let me know if any further changes

proudofsimin
proudofsimin approved these changes Jun 13, 2021
View reviewed changes
Copy link
Contributor

@proudofsimin proudofsimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The updated version is impressive :)

docusaurus/docs/specs/specs-token.md Outdated Show resolved Hide resolved
Rohitesh-Kumar-Jain
Rohitesh-Kumar-Jain approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving for PR quality

Perfect PR : clean commit history, properly based, PR good in scope.

@lijiarui
Copy link
Member

hi @shraddhavp As GSoD Project PR Review Rules in https://github.com/wechaty/wechaty.js.org/issues/1045

This PR should follow our rules and get enough approval, then I will review this PR. So I remove the ready to merge tag and feel free to add this tag when it gets enough approval.

@Rohitesh-Kumar-Jain
Copy link
Contributor

@Soumi7 We would be glad if you may once go through the PR, and either request for changes or approve the PR.

Soumi7
Soumi7 approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@Soumi7 Soumi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohitesh-Kumar-Jain
Copy link
Contributor

LGTM

Welcome back, glad to hear again from you 🎉

@Soumi7
Copy link
Contributor

Soumi7 commented Jul 17, 2021

LGTM

Welcome back, glad to hear again from you tada

Haha Thanks! Great to be back!

@shraddhavp shraddhavp mentioned this pull request Aug 1, 2021
Closed
huan
huan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

Please change the file name to specs/gateway.mdx as other files are.

After being renamed, I believe this PR will be ready to be merged.

@shraddhavp shraddhavp merged commit 145ff2b into master Sep 8, 2021
@shraddhavp shraddhavp deleted the new-token branch September 8, 2021 06:16
This was referenced Sep 9, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

@Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain Rohitesh-Kumar-Jain approved these changes

@Soumi7 Soumi7 Soumi7 approved these changes

@proudofsimin proudofsimin proudofsimin approved these changes

Assignees
No one assigned
Labels
GSoD 2021 ready to merge references
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shraddhavp @lijiarui @Rohitesh-Kumar-Jain @Soumi7 @huan @proudofsimin