Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling issue with tf2 circular dependency #4

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Handling issue with tf2 circular dependency #4

merged 4 commits into from
Jul 14, 2021

Conversation

ayrton04
Copy link
Contributor

@ayrton04 ayrton04 commented Jul 13, 2021 •
edited
Loading

svwilliams
svwilliams approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@svwilliams svwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like tf2_2d.h should #include <tf2_geometry_msgs/tf2_geometry_msgs.h> as well. That file implicitly uses the geometry_msgs conversions.

@ayrton04 ayrton04 merged commit 6b8abcc into devel Jul 14, 2021
@ayrton04 ayrton04 deleted the handle-tf2-circular-dependency branch July 14, 2021 08:10
@mikepurvis mikepurvis mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhillman anhillman anhillman approved these changes

@svwilliams svwilliams svwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrton04 @svwilliams @anhillman