Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add concat_view #36

Merged
merged 24 commits into from
Nov 9, 2024
Merged

add concat_view #36

merged 24 commits into from
Nov 9, 2024

Conversation

yaito3014
Copy link
Owner

@yaito3014 yaito3014 commented Sep 13, 2024 •
edited
Loading

fixes #35
need tests

@yaito3014 yaito3014 added enhancement New feature or request help wanted Extra attention is needed labels Sep 13, 2024
@saki7 saki7 mentioned this pull request Sep 26, 2024
Merged
@saki7
Copy link
Collaborator

saki7 commented Sep 30, 2024 •
edited
Loading

Other tests I would like to see:

  • (iter + 1 + 1 + 1) - 3 == iter
  • iter++, ++iter, iter--, --iter, mixture of these
  • size()
  • operator[]
  • assignment operators (-=, +=)
  • relational operators (for random access iterators)
  • concat(concat(...))
  • empty ranges
  • sort(concat(vec0, vec1))

@saki7 saki7 merged commit 63132b5 into main Nov 9, 2024
28 checks passed
@saki7 saki7 deleted the concat-view branch November 9, 2024 13:29
@saki7
Copy link
Collaborator

saki7 commented Nov 9, 2024

𝑺𝒖𝒑𝒆𝒓 𝑻𝒉𝒂𝒏𝒌𝒔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saki7 saki7 Awaiting requested review from saki7

Assignees

@saki7 saki7

@yaito3014 yaito3014

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yk::ranges::concat_view
2 participants
@yaito3014 @saki7