add msvc #33
Merged
add msvc #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saki7
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Since #36 is a fairly large feature, I would like to enable MSVC tests before merging it.
I was originally thinking that the naive dll copying process (as done in 5d44b6d) is not the proper resolution, but the merit of having MSVC on the matrix surpasses the downside of delaying this merge process. I guess we can live with the potential maintenance burden which would be introduced here, we can fix dll issues separately when the copying starts to fail.
@yaito3014 could you resolve the conflicts and undo the comment-outs of the test cases?
saki7
approved these changes
Sep 26, 2024
|
Super Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29