XWIKI-22680: Regression on createAndDeleteUser #3666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved consistency of the test with LinkedHashMaps. * Fixed the issue with mustMatch fields status not being updated when their pair was updated.
surli
reviewed
Nov 21, 2024
| map.put("register_password", password); | ||
| } | ||
| // We invert the order of password fields fill to test that the validation of this second password is properly | ||
| // updated when the first password field is changed. |
There was a problem hiding this comment.
I'm not a huge fan of this: the PO is not supposed to be a place where we test stuff. That being said we have TestUtils methods for registration so we're not supposed to use that method outside of tests for registration. So I guess it's ok.
Sereza7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22680 Related to https://jira.xwiki.org/browse/XWIKI-22121
fix for https://ci.xwiki.org/job/XWiki%20Environment%20Tests/job/xwiki-platform/job/stable-16.10.x/4/testReport/junit/org.xwiki.administration.test.ui/AllIT$NestedUsersGroupsRightsManagementIT/MySQL_9_1__Tomcat_9_jdk21__Chrome___Docker_tests_for_xwiki_platform_administration___Build_for_MySQL_9_1__Tomcat_9_jdk21__Chrome___Docker_tests_for_xwiki_platform_administration___createAndDeleteUser_TestUtils__TestReference_/
Changes
Description
Clarifications
Screenshots & Video
None, mostly test changes.
Executed Tests
After building changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-uiandmvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates, I could successfully passmvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/ -Dit.test=UsersGroupsRightsManagementIT#createAndDeleteUser. I tested the livevalidation changes locally and I can confirm that the changes fixed the issue.Expected merging strategy