-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWIKI-22680: Regression on createAndDeleteUser #3675
Conversation
* Fixed the wait condition at the end of the formFilling function
...test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/AbstractRegistrationPage.java
Outdated
Show resolved
Hide resolved
...orm-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/FormContainerElement.java
Outdated
Show resolved
Hide resolved
...orm-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/FormContainerElement.java
Outdated
Show resolved
Hide resolved
* Fixed the wait condition for password change
* Various code quality changes
(for each tests, I made sure to build the changes before running them) After 22aebac , rebuilt On another hand, two other fails related to yesterday's PR were solved in d0d38f0 . Successful tests to validate this: |
...orm-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/FormContainerElement.java
Outdated
Show resolved
Hide resolved
...orm-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/FormContainerElement.java
Outdated
Show resolved
Hide resolved
* Various code quality changes
* Various code quality changes
I retested changes with the updated pageobjects and could pass |
getDriver().waitUntilCondition(driver -> !getFormElement().findElement(By.name("register2_password")) | ||
.getAttribute(CLASS_ATTRIBUTE).isEmpty()); | ||
if(!valuesByElements.isEmpty()) { | ||
WebElement finalLastElement = lastElement; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need that variable, do you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code was underlined with Variable used in lambda expression should be final or effectively final
this was the quickest fix to get rid of this warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, you use it in a lambda.
if (valuesByNames.containsKey("register2_password")) { | ||
getDriver().waitUntilCondition(driver -> !getFormElement().findElement(By.name("register2_password")) | ||
.getAttribute(CLASS_ATTRIBUTE).isEmpty()); | ||
if(!valuesByElements.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now you could also check if lastElement != null :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically if the list is not empty the lastElement should be properly set at least once because we do at least one pass in the loop above . It doesn't hurt to check though . Added in 3efdb2a 👍
I didn't run tests again, I suppose this change won't break things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry my "also" was confusing, I meant you could have check only for the lastElement != null, would be more accurate given what you're doing inside. But nevermind I'll merge it like that, I've been annoying enough on this one ;)
* Various code quality changes
* Fixed the wait condition at the end of the formFilling function * Fixed the wait condition for password change (cherry picked from commit 3d67202)
* Fixed the wait condition at the end of the formFilling function * Fixed the wait condition for password change (cherry picked from commit 3d67202)
Jira URL
https://jira.xwiki.org/browse/XWIKI-22680
related to the regression introduced yesterday: https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/stable-16.10.x/7/testReport/junit/org.xwiki.administration.test.ui/AllIT$NestedRegisterIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_administration_xwiki_platform_administration_test_xwiki_platform_administration_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_administration_xwiki_platform_administration_test_xwiki_platform_administration_test_docker___registerExistingUser_boolean__boolean__boolean__TestUtils__2_/
Changes
Description
Clarifications
Screenshots & Video
None, test change only.
Executed Tests
After building the change with
mvn clean install -f xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui
, I ran all of the docker tests for administrationmvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker
. They did pass successfully. Unfortunately I wasn't able to catch a lot of those wait time issues when running locally previously, I can't be sure it doesn't fail CI until it runs here... :/Expected merging strategy