Add "hide all popovers" algorithm #8886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was requested for cross referencing instead of "hide all popovers until" here: whatwg/fullscreen#204 (comment) This patch also fixes a bug where a null endpoint is passed to hide all popovers until, but hide all popovers until assumes endpoint is not null by looking for endpoint's node document. The bug is fixed by adding a required document parameter to hide all popovers until.
4 tasks
|
I wish I had seen this before creating #8889. Oh well. |
annevk
reviewed
Feb 15, 2023
|
As part of this PR, please also double check that all the relevant terms and algorithms have been exported so whatwg/fullscreen#204 can reference them. There are some CI errors that indicate this hasn't happened yet. |
I made the new algorithm have |
These dfns need to be exported in order to be used in the fullscreen spec: whatwg/fullscreen#204
annevk
reviewed
Feb 17, 2023
annevk
reviewed
Feb 22, 2023
annevk
approved these changes
Feb 23, 2023
josepharhar
added a commit
to josepharhar/html
that referenced
this pull request
Mar 1, 2023
In whatwg#8886 I made the endpoint parameter in hide all popovers until never null by making it either a document or an element, but I forgot to change this null check to a document check. Fixes whatwg#8963
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested for cross referencing instead of "hide all popovers until" here:
whatwg/fullscreen#204 (comment)
This patch also fixes a bug where a null endpoint is passed to hide all popovers until, but hide all popovers until assumes endpoint is not null by looking for endpoint's node document. The bug is fixed by adding a required document parameter to hide all popovers until.
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )
/popover.html ( diff )