Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export some popover dfns #8885

Closed
wants to merge 1 commit into from
Closed

Export some popover dfns #8885

wants to merge 1 commit into from

Conversation

josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Feb 14, 2023 •
edited by pr-preview bot
Loading

These dfns need to be exported in order to be used in the fullscreen spec: whatwg/fullscreen#204

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)

/popover.html ( diff )

@josepharhar
Export some popover dfns
00782c9 
These dfns need to be exported in order to be used in the fullscreen
spec: whatwg/fullscreen#204
@annevk annevk added topic: popover The popover attribute and friends meta Changes to the ecosystem around the standard, not its contents labels Feb 16, 2023
annevk
annevk reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also fold this into #8886 now that #8889 is merged. As you wish.

source
state</dfn>, initially <span data-x="popover-hidden-state">hidden</span>, with these potential
values:</p>

<ul>
<li><p><dfn data-x="popover-hidden-state">hidden</dfn></p></li>
<li><p><dfn export data-dfn-for="popover visibility state"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/data-dfn-for/for/ throughout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, and I am folding this into #8886

@josepharhar josepharhar deleted the popoverexport branch February 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
meta Changes to the ecosystem around the standard, not its contents topic: popover The popover attribute and friends
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josepharhar @annevk