Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add package name #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add package name #123

wants to merge 1 commit into from

Conversation

mannix-lei
Copy link

fix #119

justinfagnani
justinfagnani requested changes May 6, 2024
View reviewed changes
schema.d.ts
@@ -22,6 +22,11 @@
* canonical export that should be used.
*/
export interface Package {
/**
* The name of the schema, it's best to be unique.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say that it's the name of the package.

We almost certainly want to namespace the package names too, since npm isn't the only package registry in town. We have at least GitHub, JSR, and internal repositories. We should discuss namespacing conventions in #119

@justinfagnani justinfagnani mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinfagnani justinfagnani justinfagnani requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package name field
2 participants
@mannix-lei @justinfagnani