Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nginx::proxy_bind #1427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add nginx::proxy_bind #1427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be02089
add nginx::proxy_bind
raemer Nov 18, 2020
438b33e
make nginx::proxy_bind optional
raemer Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions manifests/config.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
$proxy_set_header = $nginx::proxy_set_header
$proxy_hide_header = $nginx::proxy_hide_header
$proxy_pass_header = $nginx::proxy_pass_header
$proxy_bind = $nginx::proxy_bind
$sendfile = $nginx::sendfile
$server_tokens = $nginx::server_tokens
$spdy = $nginx::spdy
Expand Down
1 change: 1 addition & 0 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@
],
Array $proxy_hide_header = [],
Array $proxy_pass_header = [],
Optional[String] $proxy_bind = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you enforce the datatype a bit more? which values are valid here?

Array $proxy_ignore_header = [],
Optional[Nginx::Size] $proxy_max_temp_file_size = undef,
Optional[Nginx::Size] $proxy_busy_buffers_size = undef,
Expand Down
3 changes: 3 additions & 0 deletions templates/conf.d/nginx.conf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ http {
<% @proxy_pass_header.each do |header| -%>
proxy_pass_header <%= header %>;
<% end -%>
<% if @proxy_bind -%>
proxy_bind <%= @proxy_bind %>;
<% end -%>
<% if @proxy_headers_hash_bucket_size -%>
proxy_headers_hash_bucket_size <%= @proxy_headers_hash_bucket_size %>;
<% end -%>
Expand Down