Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nginx::proxy_bind #1427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add nginx::proxy_bind #1427

wants to merge 2 commits into from

Conversation

raemer
Copy link

@raemer raemer commented Nov 18, 2020

Pull Request (PR) description

This PR adds "proxy_bind" parameter to the nginx class. If set, it generates a config entry in nginx.conf, block "http".

@puppet-community-rangefinder
Copy link

nginx::config is a class

Breaking changes to this file MAY impact these 2 modules (near match):

nginx is a class

Breaking changes to this file WILL impact these 13 modules (exact match):
Breaking changes to this file MAY impact these 34 modules (near match):

This module is declared in 9 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak bastelfreak added enhancement New feature or request needs-rebase labels Jan 22, 2021
@@ -154,6 +154,7 @@
],
Array $proxy_hide_header = [],
Array $proxy_pass_header = [],
Optional[String] $proxy_bind = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you enforce the datatype a bit more? which values are valid here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants