Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid undefined behavior. #596

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Avoid undefined behavior. #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup_build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,15 @@ runs:
if [ "${{ inputs.ubuntu_version }}" = "22.04" ]; then sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-1.3.243-jammy.list https://packages.lunarg.com/vulkan/1.3.243/lunarg-vulkan-1.3.243-jammy.list; fi
if [ "${{ inputs.ubuntu_version }}" = "24.04" ]; then sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-noble.list https://packages.lunarg.com/vulkan/lunarg-vulkan-noble.list; fi

if [ "${{ inputs.clang_tidy}}" = "true"]; then
if [ "${{ inputs.clang_tidy }}" = "true" ]; then
wget -qO - https://apt.llvm.org/llvm-snapshot.gpg.key | gpg --dearmor - | sudo tee /usr/share/keyrings/llvm-archive-keyring.gpg >/dev/null
if [ "${{ inputs.ubuntu_version }}" = "20.04" ]; then echo 'deb [signed-by=/usr/share/keyrings/llvm-archive-keyring.gpg] http://apt.llvm.org/focal/ llvm-toolchain-focal-19 main' | sudo tee /etc/apt/sources.list.d/llvm.list >/dev/null; fi
if [ "${{ inputs.ubuntu_version }}" = "22.04" ]; then echo 'deb [signed-by=/usr/share/keyrings/llvm-archive-keyring.gpg] http://apt.llvm.org/jammy/ llvm-toolchain-jammy-19 main' | sudo tee /etc/apt/sources.list.d/llvm.list >/dev/null; fi
if [ "${{ inputs.ubuntu_version }}" = "24.04" ]; then echo 'deb [signed-by=/usr/share/keyrings/llvm-archive-keyring.gpg] http://apt.llvm.org/noble/ llvm-toolchain-noble-19 main' | sudo tee /etc/apt/sources.list.d/llvm.list >/dev/null; fi
fi

sudo apt-get update
if [ "${{ inputs.clang_tidy}}" = "true"]; then sudo apt-get install --yes clang-tidy-19; fi
if [ "${{ inputs.clang_tidy }}" = "true" ]; then sudo apt-get install --yes clang-tidy-19; fi
pip install lit clang-format==19.1.0 virtualenv
sudo apt-get install --yes doxygen
sudo apt-get install --yes vulkan-sdk
Expand Down
3 changes: 3 additions & 0 deletions modules/compiler/spirv-ll/include/spirv-ll/opcodes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class OpCode {
/// @brief Copy constructor, can be used for creating the derived classes.
OpCode(const OpCode &other, spv::Op code);

/// @brief Destructor.
virtual ~OpCode() = default;

/// @brief Return the instruction's opcode.
uint16_t opCode() const;

Expand Down
2 changes: 2 additions & 0 deletions source/vk/test/UnitVK/include/kts_vk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,8 @@ class GenericKernelTest : public ::uvk::RecordCommandBufferTest,
VkDeviceMemory deviceMemory;
VkDescriptorType descriptorType;
VkBuffer buf;

virtual ~ArgumentInfo() = default;
};

struct BufferInfo : ArgumentInfo {
Expand Down