Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid undefined behavior. #596

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Avoid undefined behavior. #596

merged 1 commit into from
Nov 21, 2024

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Nov 21, 2024

Overview

Avoid undefined behavior.

Reason for change

If we delete objects through pointers to base classes, these base classes are required to have a virtual destructor.

Description of change

Describe the intended behaviour your changes are meant to introduce to the
project and explain how they resolve the problem stated above. Detail any
relevant changes that may affect other users of the project, such as
compilation options, runtime flags, expected inputs and outputs, API entry
points, etc.

If you have added new testing, provide details on what tests you have added
and what the purpose of them is.

Anything else we should know?

If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-19 on all modified code.

If we delete objects through pointers to base classes, these base
classes are required to have a virtual destructor.
@hvdijk hvdijk merged commit 1f6562f into uxlfoundation:main Nov 21, 2024
14 checks passed
@hvdijk hvdijk deleted the avoid-ub branch November 21, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants