-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22908 MF2: Update spec tests and update implementation for recent spec changes #3198
base: main
Are you sure you want to change the base?
Conversation
Note: this PR updates the shared tests, but doesn't update the ICU4J implementation with the two spec changes, so ICU4J tests will fail in CI for now. I'll check with @mihnita about the Java side. |
We also have this new fresh issue filed: I am almost tempted to separate the tests again... |
I am tempted to say "let's drop it" We were supposed to be code freeze, and this is something that my superstition feels very strongly: submit on Friday evening :-) Even if it lands on Monday, it is still "Friday afternoon" with respect to the ICU release schedule. |
534dd57
to
fd779e9
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
… spec changes Updating the spec tests requires two implementation changes: * Match on variables rather than expressions -- see unicode-org/message-format-wg#877 * Require attribute values to be literals (if present) -- see unicode-org/message-format-wg#894 This updates the spec tests to commit 6c3704f41a9c24427126429fb43992b03609dfc8 in https://github.com/unicode-org/message-format-wg/ . Any changes following that commit will be addressed in a future PR.
fd779e9
to
ed61179
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Updating the spec tests requires two implementation changes:
Checklist