-
-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22908 DRAFT!!! MF2 ICU4J: Update spec tests and update implementation for recent spec changes #3206
base: main
Are you sure you want to change the base?
Conversation
Updated the Java code to pass the tests equivalent to #3198 The .json files are not identical, the ones here "bring back" the That is implemented, but it is an either / or, with a flag. TLDR: if we merge the 2 PRs into one, then it should contain these updated .json files, not only the Java code changes. I still think it is a bad idea to try and push for this soo late in the game. |
c6010ed
to
242d586
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
242d586
to
4396b04
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
4396b04
to
1abe585
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
…recent spec changes
1abe585
to
36235a5
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
break; | ||
} | ||
MFDataModel.Expression expression = | ||
new MFDataModel.VariableExpression(variableRef, null, new ArrayList<>()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to change the data model so that selectors are constrained to be Variable
s rather than Expression
s? (If you're trying to avoid a public API change, I understand... although that means it's possible to construct a data model that doesn't correspond to any syntactically correct message.)
@@ -122,6 +122,10 @@ | |||
{ | |||
"src": "bad {:placeholder @attribute=@foo}" | |||
}, | |||
{ | |||
"src": "bad {:placeholder @attribute=$foo}", | |||
"ignoreJava": "Unclear why would this be an error?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist