Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade golangci-lint and refactor to meet proper linting settings #564

Merged
merged 19 commits into from
May 15, 2020
Merged

Upgrade golangci-lint and refactor to meet proper linting settings #564

merged 19 commits into from
May 15, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented May 11, 2020 •
edited
Loading

What does this PR do?

This PR:

  • Updates golangci-lint to v1.27.0
  • Resets gocognit setting to proper value
  • Refactors methods to pass proper linting

Fixes #550

Additional Notes

@dtomcej dtomcej added this to the v1.3 milestone May 11, 2020
kevinpollet
kevinpollet requested changes May 12, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

As this PR is huge it would be great if someone else reviews it 👀.
Maybe @jspdown?

cmd/proxy/proxy.go Outdated Show resolved Hide resolved
cmd/proxy/proxy.go Show resolved Hide resolved
pkg/controller/service.go Outdated Show resolved Hide resolved
pkg/prepare/prepare.go Show resolved Hide resolved
pkg/prepare/prepare.go Show resolved Hide resolved
pkg/provider/provider.go Outdated Show resolved Hide resolved
pkg/provider/rule.go Outdated Show resolved Hide resolved
pkg/provider/rule.go Outdated Show resolved Hide resolved
pkg/topology/builder.go Outdated Show resolved Hide resolved
@Ullaakut
Copy link
Contributor

Ullaakut commented May 12, 2020 •
edited
Loading

@kevinpollet Harold is off for today, so I'll take a look

Ullaakut
Ullaakut suggested changes May 12, 2020
View reviewed changes
integration/integration_test.go Show resolved Hide resolved
pkg/controller/service.go Outdated Show resolved Hide resolved
pkg/k8s/client_mock.go Outdated Show resolved Hide resolved
pkg/prepare/prepare.go Outdated Show resolved Hide resolved
pkg/prepare/prepare.go Outdated Show resolved Hide resolved
pkg/provider/rule.go Outdated Show resolved Hide resolved
pkg/topology/builder.go Outdated Show resolved Hide resolved
@dtomcej dtomcej mentioned this pull request May 13, 2020
Closed
kevinpollet
kevinpollet approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM❗

Dockerfile Show resolved Hide resolved
pkg/prepare/prepare.go Show resolved Hide resolved
pkg/provider/provider.go Show resolved Hide resolved
Ullaakut
Ullaakut approved these changes May 15, 2020
View reviewed changes
pkg/topology/builder.go Show resolved Hide resolved
@jspdown jspdown mentioned this pull request May 15, 2020
Merged
@dtomcej dtomcej mentioned this pull request May 15, 2020
Closed
@traefiker traefiker merged commit a8ce34d into traefik:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

@kevinpollet kevinpollet kevinpollet approved these changes

Assignees
No one assigned
Labels
area/infrastructure area/tests kind/enhancement a new or improved feature.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Upgrade golangci-lint version to v1.26.0
4 participants
@dtomcej @Ullaakut @kevinpollet @traefiker