Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Mock should use t.log instead of fmt.Printf #578

Closed
dtomcej opened this issue May 13, 2020 · 0 comments · Fixed by #579
Closed

Client Mock should use t.log instead of fmt.Printf #578

dtomcej opened this issue May 13, 2020 · 0 comments · Fixed by #579
Labels
area/kubernetes-client area/tests kind/enhancement a new or improved feature.
Milestone
v1.3

Comments

@dtomcej
Copy link
Contributor

dtomcej commented May 13, 2020

Feature Request

Proposal

We should make the mock take a t *testing.T and to t.Log instead of Printfing.

Background

#564 (comment)

This would also make it log consistently with test logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubernetes-client area/tests kind/enhancement a new or improved feature.
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Add testing to client mock dtomcej/maesh
1 participant
@dtomcej