Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility for TYPO3 12.4 #1022

Merged
merged 26 commits into from
Mar 7, 2024
Merged

Compatibility for TYPO3 12.4 #1022

merged 26 commits into from
Mar 7, 2024

Conversation

IndyIndyIndy
Copy link
Contributor

Description

Gets everything running for TYPO3 12.4.
Unit Tests are working now, but I couldn't get the functional/acceptance tests running and am out of time.

I have

  • [/ ] Checked that CGL are followed
  • Checked that the Tests are still working
  • Added description to CHANGELOG.md (github-handle is optional)
  • Added tests for the new code

@tomasnorre
Copy link
Owner

tomasnorre commented Feb 14, 2024

Sorry for completely overlook this PR. I haven't really been able to work on the Crawler for a really long time.

Did you get it to work? Could the PR get updated, so that the CI would run again? Or did you "give" up due to no interaction.

Update: @IndyIndyIndy Could you perhaps change this PR to merge against a different branch, I would really love to credit you for your work. But I cannot merge it with the current state.

If I get merged to a WIP branch on my GitHub. I could continue were you left of.

@tomasnorre tomasnorre merged commit da5df87 into tomasnorre:main Mar 7, 2024
3 of 29 checks passed
@tomasnorre
Copy link
Owner

I have merged this, well aware that all tests aren't green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants