fix 'invalid omit_containers'

[DavidBruchmann]

Description

this commit tries to fix failing of Run jonaseberle/github-action-setup-ddev@v1 in #1022, by defining containers to omit differently.

if the mentioned run above is working now the PR could be merged, else just dump it, or remove db in omit_containers from .devbox/.ddev/config.yaml.

Note, that the whole failing tests include still another issue, which is not addressed in this commit / PR.

[DavidBruchmann]

The linked issue and the docs shine a light on this issue:

• Allow omit_containers[db] globally ddev/ddev#3718
• https://ddev.readthedocs.io/en/stable/users/configuration/config/#omit_containers
• https://ddev.readthedocs.io/en/stable/users/configuration/config/#project_tld

[tomasnorre]

Thanks. I didn't have problems with this before, and all tests are green in dev-main, but as the docs states your change is right, I have merged it.

[DavidBruchmann]

Great that it worked, thanks for the feedback!

[tomasnorre]

It's merged, but failed, due to a problem with ddev-github-action atm.
ddev/github-action-setup-ddev#27

[DavidBruchmann]

Yes, I know ;-)

Note, that the whole failing tests include still another issue, which is not addressed in this commit / PR.

[DavidBruchmann]

I'm not sure if adding db there is correct, see here: https://github.com/tomasnorre/crawler/actions/runs/8892439954/job/24416494000#step:7:1105

[tomasnorre]

I was correct. As the

Yes, I know ;-)

Note, that the whole failing tests include still another issue, which is not addressed in this commit / PR.

I overlooked that comment.

I'm not sure if adding db there is correct, see here: https://github.com/tomasnorre/crawler/actions/runs/8892439954/job/24416494000#step:7:1105

The DB setup should be right, though, but will test when I find the time and energy.

[tomasnorre]

There was a regression in the fix I merged of yours.
8d72fea

The reason it worked before with the wrong "dba" in omit_containers, was that it was never meant to be omitted. Therefore it worked before :)

I have adjusted the ddev configs, to avoid confusions like this in the future. Thanks for your contribution, without it, I would have found the problem any time soon.

[DavidBruchmann]

Great that you tackled it!
Regrettable only a small contribution from my side ;-)

[tomasnorre]

Every contribution has value.