Add support for transition tables #6901
Open
+239
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamessewell
commented
May 30, 2024
|
In the pg source there is explicit comment blocking transition tables for partitioned tables did you investigate the reason for this? I think you might have to do attribute mapping if we decide to allow this. This also needs rebase since PG13 support has been removed. |
mkindahl
force-pushed
the
js-transition-table-support-in-triggers
branch
from
19f0a37
to
f44e586
Compare
mkindahl
force-pushed
the
js-transition-table-support-in-triggers
branch
from
f44e586
to
c8c16f6
Compare
|
Note: It is possible to add a trigger on an inherited table, but that might require an attribute re-mapping so not sure we should support it. The situation where this can be a problem is if we modify the parent table (by adding and removing attributes) and then add new inherited tables they will have a different set of attribute numbers, which might require a re-mapping of the attributes. |
|
@antekresic, @erimatnor: please review this pull request.
|
mkindahl
force-pushed
the
js-transition-table-support-in-triggers
branch
from
c8c16f6
to
26fcff1
Compare
This adds support for using statement-level triggers with transition tables to hypertables and chunks of hypertables. Co-Authored-By: James Sewell <[email protected]>
mkindahl
force-pushed
the
js-transition-table-support-in-triggers
branch
from
26fcff1
to
624471d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for using statement-level triggers with transition tables to hypertables and chunks of hypertables.