Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypertable support for transition table #7513

Closed

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Dec 3, 2024

This adds support for using statement-level triggers with transition tables to hypertables and chunks of hypertables.

@mkindahl mkindahl self-assigned this Dec 3, 2024
@mkindahl mkindahl linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.07%. Comparing base (59f50f2) to head (0e6bff1).
Report is 638 commits behind head on main.

Files with missing lines Patch % Lines
src/copy.c 83.33% 0 Missing and 2 partials ⚠️
src/trigger.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7513      +/-   ##
==========================================
+ Coverage   80.06%   82.07%   +2.00%     
==========================================
  Files         190      229      +39     
  Lines       37181    43022    +5841     
  Branches     9450    10817    +1367     
==========================================
+ Hits        29770    35311    +5541     
- Misses       2997     3398     +401     
+ Partials     4414     4313     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkindahl mkindahl force-pushed the hypertable-transition-tables branch 5 times, most recently from 7e6ce55 to f44e586 Compare December 3, 2024 15:17
@mkindahl mkindahl marked this pull request as ready for review December 3, 2024 15:17
@github-actions github-actions bot requested a review from akuzm December 3, 2024 15:18
Copy link

github-actions bot commented Dec 3, 2024

@antekresic, @akuzm: please review this pull request.

Powered by pull-review

This adds support for using statement-level triggers with transition
tables to hypertables and chunks of hypertables.

Co-Authored-By: James Sewell <[email protected]>
@fabriziomello
Copy link
Contributor

Did u see that there's an WIP PR for it? #6901

@mkindahl
Copy link
Contributor Author

mkindahl commented Dec 3, 2024

Did u see that there's an WIP PR for it? #6901

Yes, I can push it there instead if you prefer that.

@mkindahl
Copy link
Contributor Author

mkindahl commented Dec 3, 2024

Did u see that there's an WIP PR for it? #6901

Yes, I can push it there instead if you prefer that.

Pushed to that branch.

@mkindahl
Copy link
Contributor Author

mkindahl commented Dec 3, 2024

Closing in favor of #6901

@mkindahl mkindahl closed this Dec 3, 2024
@mkindahl mkindahl deleted the hypertable-transition-tables branch December 3, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support transition tables in triggers on hypertable
2 participants