Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update perimeter_additional_members instructions #1038

Merged
merged 10 commits into from
Dec 12, 2023
Merged

chore: update perimeter_additional_members instructions #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b58cc1
Update perimeter_additional_membersinstructions
romanini-ciandt Nov 24, 2023
cc1c4fc
Merge branch 'master' into chore/perimeter-change
romanini-ciandt Nov 27, 2023
f838c40
Merge branch 'master' into chore/perimeter-change
romanini-ciandt Dec 1, 2023
2e61489
Merge branch 'master' into chore/perimeter-change
daniel-cit Dec 4, 2023
1952ac9
Merge branch 'master' into chore/perimeter-change
gtsorbo Dec 6, 2023
c336e65
Merge branch 'master' into chore/perimeter-change
romanini-ciandt Dec 6, 2023
56fa407
Merge branch 'master' into chore/perimeter-change
daniel-cit Dec 8, 2023
1e8b4d1
Merge branch 'master' into chore/perimeter-change
daniel-cit Dec 9, 2023
a0262af
Merge branch 'master' into chore/perimeter-change
daniel-cit Dec 11, 2023
721ec20
Merge branch 'master' into chore/perimeter-change
daniel-cit Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 3-networks-dual-svpc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ Run `terraform output cloudbuild_project_id` in the `0-bootstrap` folder to get

sed -i "s/REMOTE_STATE_BUCKET/${backend_bucket}/" ./common.auto.tfvars
```
**Note:** Make sure that you update the `perimeter_additional_members` variable with your e-mail in order to be able to view/access resources in the project protected by the VPC service controls.

1. Commit changes

Expand Down
4 changes: 2 additions & 2 deletions 3-networks-dual-svpc/common.auto.example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
// The DNS name of peering managed zone. Must end with a period.
domain = "example.com."

// Uncomment the following line and add you email in the perimeter_additional_members list.
// Update the following line and add you email in the perimeter_additional_members list.
// You must be in this list to be able to view/access resources in the project protected by the VPC service controls.

//perimeter_additional_members = ["user:[email protected]"]
perimeter_additional_members = ["user:[email protected]"]

remote_state_bucket = "REMOTE_STATE_BUCKET"
1 change: 1 addition & 0 deletions 3-networks-hub-and-spoke/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ Run `terraform output cloudbuild_project_id` in the `0-bootstrap` folder to get

sed -i "s/REMOTE_STATE_BUCKET/${backend_bucket}/" ./common.auto.tfvars
```
**Note:** Make sure that you update the `perimeter_additional_members` variable with your e-mail in order to be able to view/access resources in the project protected by the VPC service controls.

1. Commit changes

Expand Down
4 changes: 2 additions & 2 deletions 3-networks-hub-and-spoke/common.auto.example.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
// The DNS name of peering managed zone. Must end with a period.
domain = "example.com."

// Uncomment the following line and add you email in the perimeter_additional_members list.
// Update the following line and add you email in the perimeter_additional_members list.
// You must be in this list to be able to view/access resources in the project protected by the VPC service controls.

//perimeter_additional_members = ["user:[email protected]"]
perimeter_additional_members = ["user:[email protected]"]

remote_state_bucket = "REMOTE_STATE_BUCKET"

Expand Down