-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update perimeter_additional_members instructions #1038
chore: update perimeter_additional_members instructions #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than providing an uncommented bogus parameter, why don't we make it so that perimeter_additional_members
has no default value, so that it errors out when not provided?
In that case, if a user does not want to provide any members they can add [""]
@rjerrems thanks for your inputs! Nowadays, With this context, do you think that makes sense to keep this PR as is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks for the context - probably worth checking with @eeaton before merging to make sure it addresses the issue fully.
This works for me. At a future date I'm planning on doing a more thorough review of the directions in README files for this type of usability challenge, but for the scope of issue #936 that I raised, this works. |
@gtsorbo this pull request edits |
Issue #936
This PR implements an update on
perimeter_additional_members
variable declaration in both 3-networks steps.Basically, we want to avoid a situation where the user forget to uncomment a .tfvars line and because of that don't have access to a project protected by the VPC service controls. With this change, if the user forgets to fulfil the variable, an error will be raised during deploy process.