-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDESK-7381] Support source and parent async resources #2694
Conversation
@eos87 For example usage, please see the resource_parent_links test file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -21,3 +21,4 @@ exclude = ''' | |||
testpaths = ["tests", "superdesk", "apps", "content_api"] | |||
python_files = "*_test.py *_tests.py test_*.py tests_*.py tests.py test.py" | |||
asyncio_mode = "auto" | |||
asyncio_default_fixture_loop_scope = "function" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting discussion about this setting pytest-dev/pytest-asyncio#924
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I read that, seems silly to me!
Purpose
Provides the following features to async resources:
What has changed
datasource_name
attribute added to the ResourceConfig dataclassparent_links
attribute added to therest_endpoints
attribute of the ResourceConfig dataclassDocumentation
Documentation has been added to the readthedocs with an example usage and brief explanation
Resolves: SDESK-7381