Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new async Topics & Folder resources, blueprints & helper functions [NHUB-531] #1059

Merged
merged 52 commits into from
Sep 25, 2024
Merged

Create new async Topics & Folder resources, blueprints & helper functions [NHUB-531] #1059

merged 52 commits into from
Sep 25, 2024

Conversation

devketanpro
Copy link
Member

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@devketanpro devketanpro changed the title Update topic resource to async Create new async Topics & Folder resources, blueprints & helper functions [NHUB-531] Sep 2, 2024
@devketanpro devketanpro marked this pull request as draft September 2, 2024 04:08
@petrjasek petrjasek modified the milestones: v2.9, v3.0 Sep 2, 2024
eos87
eos87 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@eos87 eos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, please check it. Also the e2e tests are failing.

newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/folders_async.py Outdated Show resolved Hide resolved
newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/views.py Outdated Show resolved Hide resolved
@MarkLark86

This comment was marked as resolved.

Sign in to view
MarkLark86
MarkLark86 reviewed Sep 12, 2024
View reviewed changes
newsroom/topics/folders_async.py Outdated Show resolved Hide resolved
newsroom/topics/folders_async.py Outdated Show resolved Hide resolved
@MarkLark86 MarkLark86 mentioned this pull request Sep 13, 2024
Merged
@MarkLark86
Copy link
Contributor

@devketanpro The core PR has now been merged. Let me know how you go with using this new functionality as suggested

eos87
eos87 reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@eos87 eos87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @devketanpro, I left some comments. Please check when you have some time.

newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/topics_async.py Show resolved Hide resolved
newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/topics_async.py Outdated Show resolved Hide resolved
newsroom/topics/views.py Outdated Show resolved Hide resolved
newsroom/topics/views.py Outdated Show resolved Hide resolved
@devketanpro devketanpro merged commit 213b552 into superdesk:async Sep 25, 2024
8 checks passed
@devketanpro devketanpro deleted the NHUB-531 branch September 25, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eos87 eos87 eos87 left review comments

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@devketanpro @MarkLark86 @eos87 @petrjasek