Port WebKit 3.0 to WebKit2 4.0 API

[chimosky]

No description provided.

[chimosky]

@quozl, kindly review.

[quozl]

Thanks. Reviewed to fea2c3a.

• change the name of the callback; as it was named consistently with the signal, and now isn't,
• change the name and number of arguments of the callback to match the documentation; as the callback no longer executes properly,
• remove your change to html/es/html; it is unrelated to the port,
• test and finish porting; there are other changes you've yet to make, as the activity does work correctly; images are not loading, and the back button is not available after the first click; these problems are so severe you would have noticed them if you had tested, so it looks like you were not yet at the stage of testing,
• use more detail in commit messages, see guide to contributing; in particular your removal of set_full_content_zoom is unfortunate, yet you didn't explain why you removed it rather than use an alternative.

[chimosky]

Changes made

• change the name of the callback; as it was named consistently with the signal, and now isn't,
• remove your change to html/es/html; it is unrelated to the port,

• test and finish porting; there are other changes you've yet to make, as the activity does work correctly; images are not loading, and the back button is not available after the first click; these problems are so severe you would have noticed them if you had tested, so it looks like you were not yet at the stage of testing,

Images are loading properly for me, the back button isn't available on the first click it is on the second - click on something else first, could be home button; also occurs in v20 -

• use more detail in commit messages, see guide to contributing; in particular your removal of set_full_content_zoom is unfortunate, yet you didn't explain why you removed it rather than use an alternative.

Noted.

[quozl]

the back button isn't available on the first click it is on the second - click on something else first, could be home button; also occurs in v20 -

In my tests, it does not occur in v20 on Fedora 18, or v20 on Ubuntu 18.04.

• Please fix the back button, thanks.

Reviewed to 3af8291.

• You've removed the zoom in and zoom out buttons. Please put them back and make them work properly with the WebKit2 API. Thanks!

[chimosky]

Just thought i should share, I'll see if i can implement them.

[quozl]

Thanks, interesting. I imagine you will need to call set_zoom_level in the zoom in and out callbacks. In your 7c4d34d what's your purpose in calling set_zoom_level and passing the level that it already has set? Is there some needed side-effect?

[chimosky]

As set_full_content_zoom was removed in fea2c3a, i added it to serve as a replacement.

[chimosky]

@quozl the current zoom level seems to be working properly but requires an opposite reaction before it works again - you zoom in once then zoom out before you can zoom in again -, so basically the both buttons only work once not on multiple clicks.

[quozl]

Thanks. Let me know when you have it working correctly; zoom buttons should work as they did before.

[chimosky]

@quozl kindly review.

[quozl]

Duplicate of godiard#99