Webkit2 4.0 port

[chimosky]

No description provided.

[chimosky]

@quozl kindly review.

[quozl]

Thanks. Reviewed to efdc0ae. Tested on Ubuntu 17.10. Fixes #33.

Did this;

• rebase to master, as master has moved quite a bit since you branched from it for this port; the rebase was clean and simple, and the command was git pull --rebase origin master,
• reworked the zoom buttons, as they gave a log error when used; please review d53abd5,
• avoided use of WebKit 3.0 API name; please review a532b13,
• checked no new flake8 warnings or errors,
• tested again,
• captured screenshots of master vs this branch, for use in new issue, Broken scroll bar rendering after port to WebKit2 4.0 API #100,
• force pushed.

After your review, plan to rewrite the history on this branch before merging. New issue won't block merge.

[quozl]

Further testing exposes a latent bug; images are not shown. To reproduce, build the content, make a bundle, install it, start the activity, click on Home link, result is;

Now the _images directory is missing by design, as it is omitted from the bundle by setup.py. It works with WebKit 3.0 API browser because it accepts <img src="_images/file.png"> and is willing to look in the images directory, but the WebKit2 4.0 API browser insists on the correct file name.

ZIP format can handle symlinks, but they aren't created in the build process as far as I can see, and the exclusion in setup.py removes them. Any ideas?

[chimosky]

Further testing exposes a latent bug; images are not shown. To reproduce, build the content, make a bundle, install it, start the activity, click on Home link, result is;

I can't reproduce, images are showing in mine.

captured screenshots of master vs this branch, for use in new issue, #100,

Scrollbar rendering works fine in mine too.

I don't know why mine is Sugar 0.106 documentation after building the content and making a bundle.

[chimosky]

@quozl, i tested and i don't get the same behaviour.

[quozl]

Interesting, thanks. Please show me the contents of the bundle you built.

[chimosky]

@quozl the image is here

[quozl]

Thanks. In your bundle;

• the images/ directory contains the images (not _images/),
• the html/home_view.html file has an img tag that references _images/ (not images/).

This is technically invalid; the browser should try to open a directory _images but somehow opens a directory images.

So why is it working for you and not for me? Please suggest actions to diagnose.

[chimosky]

@quozl can you test again with sugar v0.116, I just tested and I don't face any issue you mentioned above.

[quozl]

Sure. Retested 1560ae9 by making a dist_xo bundle and installing it on he same system; Ubuntu 17.10 with Sugar 0.116.

• the images in the Home View are not shown, as before in July 2018,
• both your bundle and mine have an img tag with src set to "_images/Home_icon.png" yet there is no directory named "_images" in the directory "html", though there is a directory "images" next to the directory "html".

Neither of these are created by Sugar, so the version of Sugar is unsurprisingly ineffective.

[quozl]

Never mind, my mistake. I had not tested before your changes. Having done that, the same problem occurs, so there's no reason not to merge.

[quozl]

Rebased.