Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promo badge for incentives in MPE #9662

Draft
wants to merge 4 commits into
base: tillh/mpe-promo-badge-ui
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +2 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +2 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.4 KiB │ +2 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.9 KiB │ +2 B │ 64.2 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-ui-changes branch 5 times, most recently from 5256117 to 3734dda Compare November 20, 2024 14:43
@tillh-stripe tillh-stripe changed the base branch from tillh/ibp-incentives-model-changes to tillh/mpe-promo-badge-ui November 20, 2024 14:43
Copy link

emerge-tools bot commented Nov 20, 2024

1 build increased size, 2 builds decreased size

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
21.2.0-theme1 (20) 3.8 MB ⬇️ 3 B 8.9 MB - N/A
Financial Connections Example
com.stripe.android.financialconnections.example
21.2.0 (210200) 5.4 MB ⬇️ 801 B (-0.01%) 10.7 MB ⬆️ 266 B N/A
PaymentSheet Example
com.stripe.android.paymentsheet.example
21.2.0 (11) 8.4 MB ⬆️ 2.5 kB (0.03%) 15.7 MB ⬆️ 1.6 kB (0.01%) N/A

Stripe Identity Example 21.2.0-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: 0 B
Total download size change: ⬇️ 3 B

Largest size changes

Item Install Size Change Download Size Change
Other ⬇️ 0 B ⬇️ -3 B

Financial Connections Example 21.2.0 (210200)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 266 B
Total download size change: ⬇️ 801 B (-0.01%)

Largest size changes

Item Install Size Change Download Size Change
🗑 com.google.android.gms.signin.internal.zah ⬇️ -9.5 kB ⬇️ -4.5 kB
📝 com.google.android.gms.signin.internal.zab ⬆️ 9.4 kB ⬆️ 4.4 kB
🗑 com.stripe.android.common.coroutines.SingleKt$asSingle$1 ⬇️ -9.2 kB ⬇️ -4.3 kB
📝 androidx.appcompat.app.WindowDecorActionBar$3 ⬆️ 9.2 kB ⬆️ 4.3 kB
🗑 com.stripe.android.financialconnections.model.ConsentPane$Creator ⬇️ -8.7 kB ⬇️ -4.1 kB
View Treemap

Image of diff

PaymentSheet Example 21.2.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.6 kB (0.01%)
Total download size change: ⬆️ 2.5 kB (0.03%)

Largest size changes

Item Install Size Change Download Size Change
🗑 com.google.android.instantapps ⬇️ -10.5 kB ⬇️ -4.8 kB
📝 com.nimbusds.jose.jca.JCAContext ⬆️ 10.5 kB ⬆️ 4.8 kB
📝 com.google.android.gms.signin.internal.zab ⬆️ 8.8 kB ⬆️ 4.0 kB
🗑 com.google.android.gms.signin.internal.zah ⬇️ -8.7 kB ⬇️ -4.0 kB
🗑 com.stripe.android.payments.bankaccount.CollectBankAccountConfigu... ⬇️ -8.4 kB ⬇️ -3.8 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@tillh-stripe tillh-stripe force-pushed the tillh/mpe-promo-badge-ui branch 2 times, most recently from ea52de9 to f930bf5 Compare November 20, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant