-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PromoBadge
in horizontal and vertical elements
#9676
Draft
tillh-stripe
wants to merge
2
commits into
master
Choose a base branch
from
tillh/mpe-promo-badge-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+258
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 20, 2024 14:45
963d04f
to
c2759fe
Compare
Diffuse output:
APK
|
2 builds increased size, 1 build had no size change
Stripe Identity Example 21.2.0-theme1 (20)
|
Item | Install Size Change | Download Size Change |
---|---|---|
kotlin.collections.CollectionsKt__CollectionsKt | ⬇️ -70.9 kB | ⬇️ -33.4 kB |
🗑 com.nimbusds.jose.util.ByteUtils | ⬇️ -65.7 kB | ⬇️ -30.9 kB |
📝 com.stripe.android.lpmfoundations.paymentmethod.AddPaymentMethodR... | ⬆️ 56.0 kB | ⬆️ 26.4 kB |
📝 androidx.work.impl.model.RawWorkInfoDao_Impl | ⬆️ 53.8 kB | ⬆️ 25.3 kB |
📝 org.bouncycastle.pqc.crypto.util.PrivateKeyInfoFactory | ⬆️ 16.1 kB | ⬆️ 7.6 kB |
PaymentSheet Example 21.2.0 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.6 kB (0.01%)
Total download size change: ⬆️ 117 B
Largest size changes
Item | Install Size Change | Download Size Change |
---|---|---|
📝 androidx.compose.foundation.text.selection.TextFieldSelectionMana... | ⬆️ 28.3 kB | ⬆️ 12.9 kB |
com.google.android.gms.common.internal.service.zan | ⬇️ -27.8 kB | ⬇️ -12.7 kB |
androidx.compose.foundation.text.selection.AndroidSelectionHandle... | ⬇️ -19.7 kB | ⬇️ -9.0 kB |
androidx.compose.foundation.text.selection.HandleImageCache | ⬆️ 15.5 kB | ⬆️ 7.1 kB |
androidx.compose.foundation.text.selection.SimpleLayoutKt | ⬆️ 12.2 kB | ⬆️ 5.6 kB |
🛸 Powered by Emerge Tools
tillh-stripe
force-pushed
the
tillh/ibp-incentives-model-changes
branch
from
November 20, 2024 16:26
8c82b3e
to
33fe998
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 20, 2024 16:31
c2759fe
to
34c9015
Compare
Base automatically changed from
tillh/ibp-incentives-model-changes
to
master
November 20, 2024 16:41
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
2 times, most recently
from
November 21, 2024 16:34
ac897ef
to
a7087f2
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 21, 2024 19:34
a7087f2
to
0276b3b
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 21, 2024 20:10
0276b3b
to
90d1cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a
PromoBadge
component and renders it in the payment method tab and payment method row. It’s currently only visible in screenshot tests, but will start showing up in the sheet with #9662.Motivation
CONSUMERBANK-562
Testing
Screenshots
Changelog