Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PromoBadge in horizontal and vertical elements #9676

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Nov 20, 2024

Summary

This pull request adds a PromoBadge component and renders it in the payment method tab and payment method row. It’s currently only visible in screenshot tests, but will start showing up in the sheet with #9662.

Motivation

CONSUMERBANK-562

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +2 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +2 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 28.4 KiB │ +3 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF     
 25.3 KiB │ -3 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 54.9 KiB │ +2 B │  127 KiB │  0 B │ (total)

Copy link

emerge-tools bot commented Nov 20, 2024

2 builds increased size, 1 build had no size change

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
21.2.0-theme1 (20) 3.8 MB - 8.9 MB - N/A
Financial Connections Example
com.stripe.android.financialconnections.example
21.2.0 (210200) 5.4 MB ⬆️ 858 B (0.02%) 10.7 MB ⬆️ 1.1 kB (0.01%) N/A
PaymentSheet Example
com.stripe.android.paymentsheet.example
21.2.0 (11) 8.4 MB ⬆️ 117 B 15.7 MB ⬆️ 1.6 kB (0.01%) N/A

Stripe Identity Example 21.2.0-theme1 (20)
com.stripe.android.identity.example.theme1

No changes to report

Financial Connections Example 21.2.0 (210200)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.1 kB (0.01%)
Total download size change: ⬆️ 858 B (0.02%)

Largest size changes

Item Install Size Change Download Size Change
kotlin.collections.CollectionsKt__CollectionsKt ⬇️ -70.9 kB ⬇️ -33.4 kB
🗑 com.nimbusds.jose.util.ByteUtils ⬇️ -65.7 kB ⬇️ -30.9 kB
📝 com.stripe.android.lpmfoundations.paymentmethod.AddPaymentMethodR... ⬆️ 56.0 kB ⬆️ 26.4 kB
📝 androidx.work.impl.model.RawWorkInfoDao_Impl ⬆️ 53.8 kB ⬆️ 25.3 kB
📝 org.bouncycastle.pqc.crypto.util.PrivateKeyInfoFactory ⬆️ 16.1 kB ⬆️ 7.6 kB
View Treemap

Image of diff

PaymentSheet Example 21.2.0 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.6 kB (0.01%)
Total download size change: ⬆️ 117 B

Largest size changes

Item Install Size Change Download Size Change
📝 androidx.compose.foundation.text.selection.TextFieldSelectionMana... ⬆️ 28.3 kB ⬆️ 12.9 kB
com.google.android.gms.common.internal.service.zan ⬇️ -27.8 kB ⬇️ -12.7 kB
androidx.compose.foundation.text.selection.AndroidSelectionHandle... ⬇️ -19.7 kB ⬇️ -9.0 kB
androidx.compose.foundation.text.selection.HandleImageCache ⬆️ 15.5 kB ⬆️ 7.1 kB
androidx.compose.foundation.text.selection.SimpleLayoutKt ⬆️ 12.2 kB ⬆️ 5.6 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@tillh-stripe tillh-stripe force-pushed the tillh/ibp-incentives-model-changes branch from 8c82b3e to 33fe998 Compare November 20, 2024 16:26
Base automatically changed from tillh/ibp-incentives-model-changes to master November 20, 2024 16:41
@tillh-stripe tillh-stripe force-pushed the tillh/mpe-promo-badge-ui branch 2 times, most recently from ac897ef to a7087f2 Compare November 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant