fix the issue when we have multiple top level tags i.e. library #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle multiple top-level tags in XML nodelet files
This pull request addresses a bug found when parsing XML nodelet files that contain multiple top-level tags, which is not allowed in XML documents. The bug results in an ExpatError being raised by the xml.dom.minidom module.
In the proposed changes, we handle this scenario by reading the entire XML file into a string and manually adding a single root tag around it before parsing. This ensures that the resulting XML content always has exactly one root element, thus preventing the ExpatError.
By making this change, the script can now successfully parse XML nodelet files with multiple top-level tags, which improves its robustness and usability.