-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: poc octo run list #638
base: master
Are you sure you want to change the base?
Conversation
Using graphql is not a big deal. Just use whatever endpoint that works. Think there are a few non graphql commands used. |
Ah okay, functionality wise, do you have any feedback? |
I will give it a try when I can! |
Think it looks good. Would you want to make use of the pickers instead of the new, custom buffer? I have been using telescope recently. What do you use? Some items:
|
|
You still want there to be a buffer when you press |
Thanks for the PR @GustavEikaas! I like the idea of showing the status of the run in the preview buffer and perhaps show the logs of the run upon opening the item with |
IIRC the sequential jobs is already supported but yes I was thinking the same. |
@pwntester |
Doesnt seem like there is a good structured output for workflow logs. Will probably be tricky to have the same UI as github web. |
Nice, perhaps we can do a nested telescope selection where the use first chooses the run and then the job, that should get us a shorter log to show to the user and it should easier to print since we dont need to care about job's dependencies, just sequential steps |
I have been super busy at work so I have not had that much time to look at this but I finally got some time and this is how far I have gotten. Features
Considerations
Stdout vs zip libraryWhen mapping stdout to jobs/steps it uses string.find etc. This is error prone but pretty fast and easy way to do it. |
Important
This is a draft PR
Im making this draft PR so I can get reviews/suggestions during development
I will fill out the PR template when the PR is ready for review
Resolves: #149
Describe what this PR does / why we need it
First PR in a series of PRs to add support for github actions
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist
Feature checklist
##[group]
[command]
Remaining
Look into using graphql in favor of gh cli commands (not sure if strictly necessary but conforms to the repo standard)