Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - GitHub actions #149

Open
yingzhu146 opened this issue May 27, 2021 · 9 comments · May be fixed by #638
Open

Feature Request - GitHub actions #149

yingzhu146 opened this issue May 27, 2021 · 9 comments · May be fixed by #638
Labels
enhancement New feature or request

Comments

@yingzhu146
Copy link

yingzhu146 commented May 27, 2021

Issue Description

Type: Feature request

Describe what happened (or what feature you want)

The gh cli now offers a nice viewer for actions. As far as I know octo doesn't surface that yet? One of the few workflows I still have to do outside of octo

@pwntester
Copy link
Owner

Thanks for the suggestion, looks like a good addition

@pwntester pwntester changed the title Feature Request: GitHub actions Feature Request - GitHub actions Jul 14, 2021
@pwntester pwntester added the enhancement New feature or request label Oct 23, 2021
@GustavEikaas
Copy link

Is this on the roadmap? I use octo quite heavily for work and would like this feature. If you are open for it I can make a pull request for it @pwntester? It's quite a big scope but something basic would be a good start

@wd60622
Copy link
Collaborator

wd60622 commented Oct 11, 2024

Hi @GustavEikaas, if you can break it down into smaller PRs then that'd be great start and easiest to review. Seems like awesome feature

@GustavEikaas
Copy link

I tried making something basic just to suit my needs. Could some variant of gh-actions.nvim possibly be upstreamed in some shape or form?

@wd60622
Copy link
Collaborator

wd60622 commented Oct 13, 2024

That's awesome. Seems really useful. Do you think that it would fit into this repo easily? Maybe starting with :Octo actions list command?

What are your thoughts?

@GustavEikaas
Copy link

GustavEikaas commented Oct 14, 2024

Yeah I could take a crack at it, should be pretty straightforward to add I think. By Octo actions list do you mean listing out workflow runs or workflow definitions? I think we should try to use the same terminology as github uses.

From the cli it is

gh run list:          List recent workflow runs
gh workflow list:     List workflow files in your repository

Meaning we could do something like this

:Octo actions run list
:Octo actions workflow list

or as separate subcommands

:Octo run list
:Octo workflow list

@wd60622
Copy link
Collaborator

wd60622 commented Oct 15, 2024

Based on my understanding, the separate commands would be easiest to add. Thatd be in the commands.lua file via two new items in table. The alternative would need logic for another level of nesting which I dont think is implemented. Otherwise, youd have to treat the "list" as command to function. But I do think having all under actions makes the most sense, right?

@GustavEikaas
Copy link

Ill have a look at it hopefully today. I agree that having it all under actions would make most sense. Ill look into how much work it is to support this.

@GustavEikaas GustavEikaas linked a pull request Oct 15, 2024 that will close this issue
23 tasks
@GustavEikaas
Copy link

GustavEikaas commented Oct 15, 2024

So at this point, I have moved the list code from my plugin into octo and created the :Octo run list command. This is in the draft PR #638

There are multiple things im planning to do and the code is a mess at this point but please feel free to test out the pr to look for changes/improvements to the UI/DX. I have only ever used this for personal/work projects so there are probably plenty of ux/ui/dx issues.

To test it

  • Start a workflow in a repo
  • :Octo run list
  • <leader>o to open and track a specific run
  • Also try to open a failing workflow run to see the error message

image

Again the code is a hot mess which I will fix so dont code review it yet 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants