Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master for release v0.16.0 #153

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Update master for release v0.16.0 #153

merged 5 commits into from
Sep 7, 2023

Commits on Dec 24, 2021

  1. Configuration menu
    Copy the full SHA
    3335d0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    862e23e View commit details
    Browse the repository at this point in the history
  3. Merge tag 'v0.15.0-b1' into develop

    v0.15.0-b1 Release
    hoatle committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    521173d View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Compatibility with werkzeug 2.2 (#145)

    Compatibility with Flask>=2.2
    
    
    * Initialize base_args as class field
    
    Only include actual rule args in base_args
    
    * Fix compatibility with Werkzeug 2.2
    
    werkzeug.routing.parse_rule was considered an internal detail and has
    been removed during a refactor. We can now rely on werkzeug.routing.Rule
    which has a `arguments` field that contains the information we need.
    However, this field is not populated until the Rule has been added to a
    Map and this Map has been bound. So, we use a dummy map and bind it to
    the empty string just to get the arguments field ready for our use.
    
    * Rework test matrix, pass more exhaustive requirements to pip
    
    - EOL python versions and alpha flask have been removed from test matrix
    - Add python 3.10
    - Only test "branches" of flask and not all bugfix releases
    
    * Fix test_base_args
    
    The tested view has a route_base with no declared arguments, so we
    shouldn't expect the base_args to have a nonzero length.
    
    * Rewrite test_rule_options
    
    This test file mostly tests the same behavior over and over:
    that the options given to `FlaskView.register`, such as
    `strict_slashes`, are passed along to `Flask.add_url_rule`.
    
    It did this by testing the behavior of the view when calling
    its endpoints with or without the trailing slash, expecting it
    to return the same response.
    
    However, werkzeug never guaranteed this behavior. The only
    documented behavior tunable by this option is:
    
    "If strict_slashes is enabled (the default), visiting a branch URL
    without a trailing slash will redirect to the URL with a slash
    appended."
    
    So, with the reimplementation of the routing in werkzeug 2.2, this
    behavior is lost.
    
    Instead of testing the behavior of the view, let's mock `add_url_rule`
    and check that it's called with `strict_slashes` as `False`.
    
    * Fix test_blueprints
    
    Flask >=2.2 raises an error when trying to apply changes to an app
    which has already serviced requests. For this specific test, we can
    redefine the app.
    
    * Pass rule_options to add_url_rules when adding a @route-ed rule
    
    * Remove nose which is deprecated, use pytest
    superseed authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    adc3bcf View commit details
    Browse the repository at this point in the history
  2. docs: add changelog entry and bump version (#151)

    Signed-off-by: F.N. Claessen <[email protected]>
    Flix6x authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    53513e4 View commit details
    Browse the repository at this point in the history