Update master for release v0.16.0 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0.15.0-b1 Release
Compatibility with Flask>=2.2 * Initialize base_args as class field Only include actual rule args in base_args * Fix compatibility with Werkzeug 2.2 werkzeug.routing.parse_rule was considered an internal detail and has been removed during a refactor. We can now rely on werkzeug.routing.Rule which has a `arguments` field that contains the information we need. However, this field is not populated until the Rule has been added to a Map and this Map has been bound. So, we use a dummy map and bind it to the empty string just to get the arguments field ready for our use. * Rework test matrix, pass more exhaustive requirements to pip - EOL python versions and alpha flask have been removed from test matrix - Add python 3.10 - Only test "branches" of flask and not all bugfix releases * Fix test_base_args The tested view has a route_base with no declared arguments, so we shouldn't expect the base_args to have a nonzero length. * Rewrite test_rule_options This test file mostly tests the same behavior over and over: that the options given to `FlaskView.register`, such as `strict_slashes`, are passed along to `Flask.add_url_rule`. It did this by testing the behavior of the view when calling its endpoints with or without the trailing slash, expecting it to return the same response. However, werkzeug never guaranteed this behavior. The only documented behavior tunable by this option is: "If strict_slashes is enabled (the default), visiting a branch URL without a trailing slash will redirect to the URL with a slash appended." So, with the reimplementation of the routing in werkzeug 2.2, this behavior is lost. Instead of testing the behavior of the view, let's mock `add_url_rule` and check that it's called with `strict_slashes` as `False`. * Fix test_blueprints Flask >=2.2 raises an error when trying to apply changes to an app which has already serviced requests. For this specific test, we can redefine the app. * Pass rule_options to add_url_rules when adding a @route-ed rule * Remove nose which is deprecated, use pytest
Signed-off-by: F.N. Claessen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.