DNM - first pass at including velero-openstack plugin

api/v1alpha1/cloud_storage_types.go

@@ -21,9 +21,10 @@ type CloudStorage struct {
 type CloudStorageProvider string
 
 const (
-	AWSBucketProvider   CloudStorageProvider = CloudStorageProvider(DefaultPluginAWS)
-	AzureBucketProvider CloudStorageProvider = CloudStorageProvider(DefaultPluginMicrosoftAzure)
-	GCPBucketProvider   CloudStorageProvider = CloudStorageProvider(DefaultPluginGCP)
+	AWSBucketProvider       CloudStorageProvider = CloudStorageProvider(DefaultPluginAWS)
+	AzureBucketProvider     CloudStorageProvider = CloudStorageProvider(DefaultPluginMicrosoftAzure)
+	GCPBucketProvider       CloudStorageProvider = CloudStorageProvider(DefaultPluginGCP)
+	OpenStackBucketProvider CloudStorageProvider = CloudStorageProvider(DefaultPluginOpenStack)
 )
 
 type CloudStorageSpec struct {

api/v1alpha1/oadp_types.go

@@ -35,7 +35,7 @@ const ReconcileCompleteMessage = "Reconcile complete"
 const OadpOperatorLabel = "openshift.io/oadp"
 const RegistryDeploymentLabel = "openshift.io/oadp-registry"
 
-// +kubebuilder:validation:Enum=aws;legacy-aws;gcp;azure;csi;vsm;openshift;kubevirt
+// +kubebuilder:validation:Enum=aws;legacy-aws;gcp;azure;csi;vsm;openshift;kubevirt;openstack
 type DefaultPlugin string
 
 const DefaultPluginAWS DefaultPlugin = "aws"
@@ -46,6 +46,7 @@ const DefaultPluginCSI DefaultPlugin = "csi"
 const DefaultPluginVSM DefaultPlugin = "vsm"
 const DefaultPluginOpenShift DefaultPlugin = "openshift"
 const DefaultPluginKubeVirt DefaultPlugin = "kubevirt"
+const DefaultPluginOpenStack DefaultPlugin = "openstack"
 
 type CustomPlugin struct {
 	Name  string `json:"name"`
@@ -63,6 +64,7 @@ const AzurePluginImageKey UnsupportedImageKey = "azurePluginImageFqin"
 const GCPPluginImageKey UnsupportedImageKey = "gcpPluginImageFqin"
 const ResticRestoreImageKey UnsupportedImageKey = "resticRestoreImageFqin"
 const KubeVirtPluginImageKey UnsupportedImageKey = "kubevirtPluginImageFqin"
+const OpenStackPluginImageKey UnsupportedImageKey = "openstackPluginImageFqin"
 const NonAdminControllerImageKey UnsupportedImageKey = "nonAdminControllerImageFqin"
 const OperatorTypeKey UnsupportedImageKey = "operator-type"
 const TechPreviewAck UnsupportedImageKey = "tech-preview-ack"
@@ -557,6 +559,7 @@ type DataProtectionApplicationSpec struct {
 	//   - awsPluginImageFqin
 	//   - legacyAWSPluginImageFqin
 	//   - openshiftPluginImageFqin
+	//   - openstackPluginImageFqin
 	//   - azurePluginImageFqin
 	//   - gcpPluginImageFqin
 	//   - resticRestoreImageFqin

bundle/manifests/oadp-operator.clusterserviceversion.yaml

@@ -942,6 +942,8 @@ spec:
                   value: quay.io/konveyor/velero-plugin-for-microsoft-azure:latest
                 - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_GCP
                   value: quay.io/konveyor/velero-plugin-for-gcp:latest
+                - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_OPENSTACK
+                  value: quay.io/konveyor/velero-plugin-for-openstack:latest
                 - name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN
                   value: quay.io/konveyor/kubevirt-velero-plugin:v0.7.0
                 - name: RELATED_IMAGE_MUSTGATHER
@@ -1095,6 +1097,8 @@ spec:
     name: velero-plugin-for-microsoft-azure
   - image: quay.io/konveyor/velero-plugin-for-gcp:latest
     name: velero-plugin-for-gcp
+  - image: quay.io/konveyor/velero-plugin-for-openstack:latest
+    name: velero-plugin-for-openstack
   - image: quay.io/konveyor/kubevirt-velero-plugin:v0.7.0
     name: kubevirt-velero-plugin
   - image: registry.redhat.io/oadp/oadp-mustgather-rhel8:v1.2

bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml

@@ -831,6 +831,7 @@ spec:
                               - vsm
                               - openshift
                               - kubevirt
+                              - openstack
                             type: string
                           type: array
                         defaultSnapshotMoveData:
@@ -1776,6 +1777,7 @@ spec:
                       - awsPluginImageFqin
                       - legacyAWSPluginImageFqin
                       - openshiftPluginImageFqin
+                      - openstackPluginImageFqin
                       - azurePluginImageFqin
                       - gcpPluginImageFqin
                       - resticRestoreImageFqin

config/manager/manager.yaml

@@ -56,6 +56,8 @@ spec:
             value: quay.io/konveyor/velero-plugin-for-microsoft-azure:latest
           - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_GCP
             value: quay.io/konveyor/velero-plugin-for-gcp:latest
+          - name: RELATED_IMAGE_VELERO_PLUGIN_FOR_OPENSTACK
+            value: quay.io/konveyor/velero-plugin-for-openstack:latest
           - name: RELATED_IMAGE_KUBEVIRT_VELERO_PLUGIN
             value: quay.io/konveyor/kubevirt-velero-plugin:v0.7.0
           - name: RELATED_IMAGE_MUSTGATHER

controllers/bsl.go

@@ -65,6 +65,11 @@ func (r *DPAReconciler) ValidateBackupStorageLocations() (bool, error) {
 				if err != nil {
 					return false, err
 				}
+			case OpenstackProvider, "community.openstack.org/openstack":
+				err := r.validateOpenstackBackupStorageLocation(*bslSpec.Velero)
+				if err != nil {
+					return false, err
+				}
 			default:
 				return false, fmt.Errorf("invalid provider")
 			}
@@ -399,6 +404,29 @@ func (r *DPAReconciler) validateGCPBackupStorageLocation(bslSpec velerov1.Backup
 	return nil
 }
 
+func (r *DPAReconciler) validateOpenstackBackupStorageLocation(bslSpec velerov1.BackupStorageLocationSpec) error {
+	// validate provider plugin and secret
+	err := r.validateProviderPluginAndSecret(bslSpec)
+	if err != nil {
+		return err
+	}
+
+	// check for bsl non-optional bsl configs and object storage
+	if bslSpec.ObjectStorage == nil {
+		return fmt.Errorf("object storage configuration for OpenStack backupstoragelocation cannot be nil")
+	}
+
+	if len(bslSpec.ObjectStorage.Bucket) == 0 {
+		return fmt.Errorf("bucket name for OpenStack backupstoragelocation cannot be empty")
+	}
+
+	if len(bslSpec.StorageType.ObjectStorage.Prefix) == 0 && r.dpa.BackupImages() {
+		return fmt.Errorf("prefix for OpenStack backupstoragelocation object storage cannot be empty. it is required for backing up images")
+	}
+
+	return nil
+}
+
 func pluginExistsInVeleroCR(configuredPlugins []oadpv1alpha1.DefaultPlugin, expectedProvider string) bool {
 	for _, plugin := range configuredPlugins {
 		if credentials.PluginSpecificFields[plugin].ProviderName == expectedProvider {

controllers/registry.go

@@ -57,6 +57,7 @@ const (
 	AWSProvider           = "aws"
 	AzureProvider         = "azure"
 	GCPProvider           = "gcp"
+	OpenstackProvider     = "openstack"
 	Region                = "region"
 	Profile               = "profile"
 	S3URL                 = "s3Url"

docs/config/plugins.md

@@ -18,6 +18,7 @@ installing Velero:
    - `OpenShift` [OpenShift Velero Plugin](https://github.com/openshift/openshift-velero-plugin)
    - `CSI` [Plugins for CSI](https://github.com/vmware-tanzu/velero-plugin-for-csi)
    - `kubevirt` [Plugins for Kubevirt](https://github.com/kubevirt/kubevirt-velero-plugin)
+   - `Openstack` [Plugins for Openstack](https://github.com/openshift/lirt-velero-plugin-for-openstack)
    - `VSM (OADP 1.2 or below)` [Plugin for Volume-Snapshot-Mover](https://github.com/migtools/velero-plugin-for-vsm)
 
    Note that only one of `AWS` and `Legacy AWS` may be installed at the same time. `Legacy AWS` is intended for use with certain S3 providers that do not support the V2 AWS SDK APIs used in the `AWS` plugin.

hack/disconnected-prep.sh

@@ -31,6 +31,7 @@ IMG_MAP[gcpplugin_repo]="velero-plugin-for-gcp"
 IMG_MAP[awsplugin_repo]="velero-plugin-for-aws"
 IMG_MAP[legacyawsplugin_repo]="velero-plugin-for-legacy-aws"
 IMG_MAP[azureplugin_repo]="velero-plugin-for-microsoft-azure"
+IMG_MAP[openstackplugin_repo]="velero-plugin-for-openstack"
 IMG_MAP[registry_repo]="registry"
 
 #Get latest images

pkg/common/common.go

@@ -68,6 +68,7 @@ const (
 	GCPPluginImage       = "quay.io/konveyor/velero-plugin-for-gcp:latest"
 	RegistryImage        = "quay.io/konveyor/registry:latest"
 	KubeVirtPluginImage  = "quay.io/konveyor/kubevirt-velero-plugin:v0.7.0"
+	OpenstackPluginImage = "quay.io/konveyor/velero-plugin-for-openstack:latest"
 )
 
 // Plugin names
@@ -78,6 +79,7 @@ const (
 	VeleroPluginForGCP       = "velero-plugin-for-gcp"
 	VeleroPluginForOpenshift = "openshift-velero-plugin"
 	KubeVirtPlugin           = "kubevirt-velero-plugin"
+	VeleroPluginForOpenstack = "velero-plugin-for-openstack"
 )
 
 // Environment Vars keys