Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM - first pass at including velero-openstack plugin #1592

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

weshayutin
Copy link
Contributor

Why the changes were made

Adding the velero-plugin-for-openstack as a tech-preview image for master and future oadp-1.5 branch

How to test the changes made

make deploy-olm
add the "openstack" plugin to the list of plugins in the dpa. That's it for now.

@weshayutin weshayutin self-assigned this Nov 19, 2024
@weshayutin weshayutin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@weshayutin weshayutin changed the title first pass at including velero-openstack plugin DNM - first pass at including velero-openstack plugin Nov 19, 2024
Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weshayutin
Once this PR has been reviewed and has the lgtm label, please assign dymurray for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin
Copy link
Contributor Author

hrm.. hitting

status:
  lastValidationTime: "2024-11-22T19:22:19Z"
  message: 'BackupStorageLocation "dpa-sample-1" is unavailable: unable to locate
    ObjectStore plugin named velero.io/openstack'

I have it defined as:

	case OpenstackProvider, "community.openstack.org/openstack":
				err := r.validateOpenstackBackupStorageLocation(*bslSpec.Velero)
				if err != nil {

@shubham-pampattiwar
Copy link
Member

hrm.. hitting

status:
  lastValidationTime: "2024-11-22T19:22:19Z"
  message: 'BackupStorageLocation "dpa-sample-1" is unavailable: unable to locate
    ObjectStore plugin named velero.io/openstack'

I have it defined as:

	case OpenstackProvider, "community.openstack.org/openstack":
				err := r.validateOpenstackBackupStorageLocation(*bslSpec.Velero)
				if err != nil {

Velero is looking for a plugin named velero.io/openstack and the plugin is being registered as community.openstack.org/openstack

Copy link

openshift-ci bot commented Nov 22, 2024

@weshayutin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images f04c63a link true /test images
ci/prow/4.17-e2e-test-kubevirt-aws f04c63a link true /test 4.17-e2e-test-kubevirt-aws
ci/prow/4.16-e2e-test-kubevirt-aws f04c63a link true /test 4.16-e2e-test-kubevirt-aws
ci/prow/4.17-e2e-test-aws f04c63a link true /test 4.17-e2e-test-aws
ci/prow/4.14-e2e-test-kubevirt-aws f04c63a link true /test 4.14-e2e-test-kubevirt-aws
ci/prow/4.14-e2e-test-aws f04c63a link true /test 4.14-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants