refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml

[Juneezee]

The package github.com/ghodss/yaml is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

[openshift-ci]

Hi @Juneezee. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[r4f4]

/ok-to-test

[r4f4]

Is there some place left still using github.com/ghodss/yaml? I'd expect vendoring changes to remove that dep.

[Juneezee]

Is there some place left still using github.com/ghodss/yaml? I'd expect vendoring changes to remove that dep.

@r4f4 One of our dependency https://github.com/openshift/cluster-api-provider-libvirt is still using github.com/ghodss/yaml.

$ go mod why -m github.com/ghodss/yaml
# github.com/ghodss/yaml
github.com/openshift/installer/pkg/asset/cluster
github.com/openshift/cluster-api-provider-libvirt/pkg/apis/libvirtproviderconfig/v1beta1
github.com/ghodss/yaml

[r4f4]

Is there some place left still using github.com/ghodss/yaml? I'd expect vendoring changes to remove that dep.

@r4f4 One of our dependency https://github.com/openshift/cluster-api-provider-libvirt is still using github.com/ghodss/yaml.

$ go mod why -m github.com/ghodss/yaml
# github.com/ghodss/yaml
github.com/openshift/installer/pkg/asset/cluster
github.com/openshift/cluster-api-provider-libvirt/pkg/apis/libvirtproviderconfig/v1beta1
github.com/ghodss/yaml

So maybe we could use a replace directive to take care of that until cluster-api-provider-libvirt moves away from it?

replace github.com/ghodss/yaml => sigs.k8s.io/yaml

[Juneezee]

So maybe we could use a replace directive to take care of that until cluster-api-provider-libvirt moves away from it?

replace github.com/ghodss/yaml => sigs.k8s.io/yaml

@r4f4 Go doesn't seem to allow this

$ go mod tidy
go: sigs.k8s.io/[email protected] used for two different module paths (github.com/ghodss/yaml and sigs.k8s.io/yaml)

Is it okay if I go open a PR in https://github.com/openshift/cluster-api-provider-libvirt to replace github.com/ghodss/yaml with sigs.k8s.io/yaml?

[r4f4]

So maybe we could use a replace directive to take care of that until cluster-api-provider-libvirt moves away from it?

replace github.com/ghodss/yaml => sigs.k8s.io/yaml

@r4f4 Go doesn't seem to allow this

$ go mod tidy
go: sigs.k8s.io/[email protected] used for two different module paths (github.com/ghodss/yaml and sigs.k8s.io/yaml)

Oh I see.

Is it okay if I go open a PR in https://github.com/openshift/cluster-api-provider-libvirt to replace github.com/ghodss/yaml with sigs.k8s.io/yaml?

Yep, I think that's the proper way to solve this problem.

[Juneezee]

Marking this PR as draft until openshift/cluster-api-provider-libvirt#252 is merged.

[r4f4]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[barbacbd]

/lgtm

[openshift-ci]

@Juneezee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-libvirt	107b012	link	false	/test e2e-libvirt
ci/prow/okd-scos-e2e-aws-ovn	107b012	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack	107b012	link	false	/test e2e-azurestack
ci/prow/e2e-gcp-ovn-shared-vpc	107b012	link	false	/test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-aws-ovn-workers-rhel8	107b012	link	false	/test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-e2e-aws-upgrade	107b012	link	false	/test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade	107b012	link	false	/test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.