Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #252

Merged
merged 1 commit into from
Mar 8, 2023
Merged

refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #252

merged 1 commit into from
Mar 8, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Mar 7, 2023

The package github.com/ghodss/yaml is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml.

The notable change is that github.com/ghodss/yaml uses gopkg.in/yaml.v2 v2.2.2, but sigs.k8s.io/yaml uses gopkg.in/yaml.v2 v2.4.0. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.

Related PR: openshift/installer#6935

@Juneezee
refactor: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
301318b 
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2023
@openshift-ci openshift-ci bot requested a review from enxebre March 7, 2023 12:25
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

Hi @Juneezee. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gbraad March 7, 2023 12:25
@Juneezee
Copy link
Contributor Author

Juneezee commented Mar 7, 2023

/cc @r4f4

@openshift-ci openshift-ci bot requested a review from r4f4 March 7, 2023 12:25
@Juneezee Juneezee mentioned this pull request Mar 7, 2023
Merged
@r4f4
Copy link

r4f4 commented Mar 7, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2023

@Juneezee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 301318b link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

r4f4
r4f4 reviewed Mar 7, 2023
View reviewed changes
Copy link

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2023
@r4f4 r4f4 removed their assignment Mar 7, 2023
@cfergeau
Copy link
Contributor

cfergeau commented Mar 8, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@cfergeau
Copy link
Contributor

cfergeau commented Mar 8, 2023

The e2e-libvirt failure is a known one, and unrelated to this PR.

@openshift-merge-robot openshift-merge-robot merged commit 83c0473 into openshift:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@enxebre enxebre Awaiting requested review from enxebre

@gbraad gbraad Awaiting requested review from gbraad

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Juneezee @r4f4 @cfergeau @openshift-merge-robot