Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid patching gameserver continuously #124

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

chrisliu1995
Copy link
Member

No description provided.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (02c0009) 35.55% compared to head (ce8ed5e) 39.12%.

Files Patch % Lines
...kg/controllers/gameserver/gameserver_controller.go 0.00% 35 Missing ⚠️
pkg/controllers/gameserver/gameserver_manager.go 54.83% 10 Missing and 4 partials ⚠️
...kg/controllers/gameserver/gameserver_conditions.go 79.06% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   35.55%   39.12%   +3.56%     
==========================================
  Files          26       26              
  Lines        3535     3581      +46     
==========================================
+ Hits         1257     1401     +144     
+ Misses       2213     2098     -115     
- Partials       65       82      +17     
Flag Coverage Δ
unittests 39.12% <46.78%> (+3.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 2b6ce6f into openkruise:master Jan 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants