fix: avoid patching gameserver continuously

Signed-off-by: ChrisLiu <[email protected]>

pkg/controllers/controller.go

@@ -17,10 +17,13 @@ limitations under the License.
 package controller
 
 import (
+	"context"
 	"github.com/openkruise/kruise-game/pkg/controllers/gameserver"
 	"github.com/openkruise/kruise-game/pkg/controllers/gameserverset"
+	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/meta"
 	"k8s.io/klog/v2"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 )
 
@@ -32,6 +35,13 @@ func init() {
 }
 
 func SetupWithManager(m manager.Manager) error {
+	if err := m.GetFieldIndexer().IndexField(context.Background(), &corev1.Pod{}, "spec.nodeName", func(rawObj client.Object) []string {
+		pod := rawObj.(*corev1.Pod)
+		return []string{pod.Spec.NodeName}
+	}); err != nil {
+		return err
+	}
+
 	for _, f := range controllerAddFuncs {
 		if err := f(m); err != nil {
 			if kindMatchErr, ok := err.(*meta.NoKindMatchError); ok {

pkg/controllers/gameserver/gameserver_conditions.go

@@ -172,18 +172,16 @@ func getPodConditions(pod *corev1.Pod) gamekruiseiov1alpha1.GameServerCondition
 
 	if message == "" && reason == "" {
 		return gamekruiseiov1alpha1.GameServerCondition{
-			Type:          gamekruiseiov1alpha1.PodNormal,
-			Status:        corev1.ConditionTrue,
-			LastProbeTime: metav1.Now(),
+			Type:   gamekruiseiov1alpha1.PodNormal,
+			Status: corev1.ConditionTrue,
 		}
 	}
 
 	return gamekruiseiov1alpha1.GameServerCondition{
-		Type:          gamekruiseiov1alpha1.PodNormal,
-		Status:        corev1.ConditionFalse,
-		Reason:        reason,
-		Message:       message,
-		LastProbeTime: metav1.Now(),
+		Type:    gamekruiseiov1alpha1.PodNormal,
+		Status:  corev1.ConditionFalse,
+		Reason:  reason,
+		Message: message,
 	}
 }
 
@@ -216,7 +214,7 @@ func getNodeConditions(node *corev1.Node) gamekruiseiov1alpha1.GameServerConditi
 
 	for _, condition := range node.Status.Conditions {
 		switch condition.Type {
-		case corev1.NodeReady:
+		case corev1.NodeReady, "SufficientIP":
 			if condition.Status != corev1.ConditionTrue {
 				message, reason = polyMessageReason(message, reason, condition.Message, string(condition.Type)+":"+condition.Reason)
 			}
@@ -229,18 +227,16 @@ func getNodeConditions(node *corev1.Node) gamekruiseiov1alpha1.GameServerConditi
 
 	if message == "" && reason == "" {
 		return gamekruiseiov1alpha1.GameServerCondition{
-			Type:          gamekruiseiov1alpha1.NodeNormal,
-			Status:        corev1.ConditionTrue,
-			LastProbeTime: metav1.Now(),
+			Type:   gamekruiseiov1alpha1.NodeNormal,
+			Status: corev1.ConditionTrue,
 		}
 	}
 
 	return gamekruiseiov1alpha1.GameServerCondition{
-		Type:          gamekruiseiov1alpha1.NodeNormal,
-		Status:        corev1.ConditionFalse,
-		Reason:        reason,
-		Message:       message,
-		LastProbeTime: metav1.Now(),
+		Type:    gamekruiseiov1alpha1.NodeNormal,
+		Status:  corev1.ConditionFalse,
+		Reason:  reason,
+		Message: message,
 	}
 }
 
@@ -256,38 +252,34 @@ func getPersistentVolumeConditions(pvs []*corev1.PersistentVolume) gamekruiseiov
 
 	if message == "" && reason == "" {
 		return gamekruiseiov1alpha1.GameServerCondition{
-			Type:          gamekruiseiov1alpha1.PersistentVolumeNormal,
-			Status:        corev1.ConditionTrue,
-			LastProbeTime: metav1.Now(),
+			Type:   gamekruiseiov1alpha1.PersistentVolumeNormal,
+			Status: corev1.ConditionTrue,
 		}
 	}
 
 	return gamekruiseiov1alpha1.GameServerCondition{
-		Type:          gamekruiseiov1alpha1.PersistentVolumeNormal,
-		Status:        corev1.ConditionFalse,
-		Reason:        reason,
-		Message:       message,
-		LastProbeTime: metav1.Now(),
+		Type:    gamekruiseiov1alpha1.PersistentVolumeNormal,
+		Status:  corev1.ConditionFalse,
+		Reason:  reason,
+		Message: message,
 	}
 }
 
 func pvcNotFoundCondition(namespace, pvcName string) gamekruiseiov1alpha1.GameServerCondition {
 	return gamekruiseiov1alpha1.GameServerCondition{
-		Type:          gamekruiseiov1alpha1.PersistentVolumeNormal,
-		Status:        corev1.ConditionFalse,
-		Reason:        pvcNotFoundReason,
-		Message:       fmt.Sprintf("There is no pvc named %s/%s in cluster", namespace, pvcName),
-		LastProbeTime: metav1.Now(),
+		Type:    gamekruiseiov1alpha1.PersistentVolumeNormal,
+		Status:  corev1.ConditionFalse,
+		Reason:  pvcNotFoundReason,
+		Message: fmt.Sprintf("There is no pvc named %s/%s in cluster", namespace, pvcName),
 	}
 }
 
 func pvNotFoundCondition(namespace, pvcName string) gamekruiseiov1alpha1.GameServerCondition {
 	return gamekruiseiov1alpha1.GameServerCondition{
-		Type:          gamekruiseiov1alpha1.PersistentVolumeNormal,
-		Status:        corev1.ConditionFalse,
-		Reason:        pvNotFoundReason,
-		Message:       fmt.Sprintf("There is no pv which pvc %s/%s is bound with", namespace, pvcName),
-		LastProbeTime: metav1.Now(),
+		Type:    gamekruiseiov1alpha1.PersistentVolumeNormal,
+		Status:  corev1.ConditionFalse,
+		Reason:  pvNotFoundReason,
+		Message: fmt.Sprintf("There is no pv which pvc %s/%s is bound with", namespace, pvcName),
 	}
 }
 
@@ -371,3 +363,26 @@ func isConditionEqual(a, b gamekruiseiov1alpha1.GameServerCondition) bool {
 	}
 	return true
 }
+
+func isConditionsEqual(a, b []gamekruiseiov1alpha1.GameServerCondition) bool {
+	if len(a) != len(b) {
+		return false
+	}
+
+	for _, aCondition := range a {
+		found := false
+		for _, bCondition := range b {
+			if aCondition.Type == bCondition.Type {
+				found = true
+				if !isConditionEqual(aCondition, bCondition) {
+					return false
+				}
+			}
+		}
+		if !found {
+			return false
+		}
+	}
+
+	return true
+}

pkg/controllers/gameserver/gameserver_controller.go

@@ -24,12 +24,16 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/fields"
+	"k8s.io/apimachinery/pkg/labels"
 	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/selection"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/tools/record"
 	"k8s.io/client-go/util/workqueue"
 	"k8s.io/klog/v2"
 	"k8s.io/utils/pointer"
+	"reflect"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller"
@@ -80,6 +84,10 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error {
 		klog.Error(err)
 		return err
 	}
+	if err = watchNode(c, mgr.GetClient()); err != nil {
+		klog.Error(err)
+		return err
+	}
 
 	return nil
 }
@@ -128,6 +136,40 @@ func watchPod(c controller.Controller) error {
 	return nil
 }
 
+func watchNode(c controller.Controller, cli client.Client) error {
+	if err := c.Watch(&source.Kind{Type: &corev1.Node{}}, &handler.Funcs{
+		UpdateFunc: func(updateEvent event.UpdateEvent, limitingInterface workqueue.RateLimitingInterface) {
+			nodeNew := updateEvent.ObjectNew.(*corev1.Node)
+			nodeOld := updateEvent.ObjectOld.(*corev1.Node)
+			if reflect.DeepEqual(nodeNew.Status.Conditions, nodeOld.Status.Conditions) {
+				return
+			}
+			podList := &corev1.PodList{}
+			ownerGss, _ := labels.NewRequirement(gamekruiseiov1alpha1.GameServerOwnerGssKey, selection.Exists, []string{})
+			err := cli.List(context.Background(), podList, &client.ListOptions{
+				LabelSelector: labels.NewSelector().Add(*ownerGss),
+				FieldSelector: fields.Set{"spec.nodeName": nodeNew.Name}.AsSelector(),
+			})
+			if err != nil {
+				klog.Errorf("List Pods By NodeName failed: %s", err.Error())
+				return
+			}
+			for _, pod := range podList.Items {
+				klog.Infof("Watch Node %s Conditions Changed, adding pods %s/%s in reconcile queue", nodeNew.Name, pod.Namespace, pod.Name)
+				limitingInterface.Add(reconcile.Request{
+					NamespacedName: types.NamespacedName{
+						Namespace: pod.GetNamespace(),
+						Name:      pod.GetName(),
+					},
+				})
+			}
+		},
+	}); err != nil {
+		return err
+	}
+	return nil
+}
+
 //+kubebuilder:rbac:groups=game.kruise.io,resources=gameservers,verbs=get;list;watch;create;update;patch;delete
 //+kubebuilder:rbac:groups=game.kruise.io,resources=gameservers/status,verbs=get;update;patch
 //+kubebuilder:rbac:groups=game.kruise.io,resources=gameservers/finalizers,verbs=update