Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setCookie [SSR]: Do not override existing cookies with new one. #183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

setCookie [SSR]: Do not override existing cookies with new one. #183

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28c1ad1
fix: set-cookie should not override existing cookies
misterpekert May 25, 2021
2e60d40
Merge branch 'nuxt-community:master' into master
misterpekert Nov 24, 2021
5e4aa21
Merge branch 'nuxt-community:master' into master
misterpekert Jan 3, 2023
854acf5
add check if 'Set-Cookie' header is empty.
misterpekert Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,11 @@ export class Storage implements NuxtStorage {
document.cookie = serializedCookie
} else if (process.server && this.ctx.res) {
// Send Set-Cookie header from server side
this.ctx.res.setHeader('Set-Cookie', [serializedCookie])
const existingCookies = this.ctx.res.getHeader('Set-Cookie')
const cookies = Array.isArray(existingCookies)
? [...existingCookies, serializedCookie]
: [existingCookies, serializedCookie]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if existingCookies is null?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farzadso should be good now. Thanks for noticing!

this.ctx.res.setHeader('Set-Cookie', cookies)
}

return value
Expand Down