setCookie [SSR]: Do not override existing cookies with new one. #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterpekert
changed the title
|
@pi0 any chance this will get reviewed and released? 🤔 |
|
Any updates? |
|
@farzadso is this project still being maintained? This PR is already 3m without any feedback. |
|
1 year passed, who cares, right? :) |
farzadso
reviewed
Sep 27, 2022
| const existingCookies = this.ctx.res.getHeader('Set-Cookie') | ||
| const cookies = Array.isArray(existingCookies) | ||
| ? [...existingCookies, serializedCookie] | ||
| : [existingCookies, serializedCookie] |
There was a problem hiding this comment.
What happens if existingCookies is null?
There was a problem hiding this comment.
@farzadso should be good now. Thanks for noticing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per setHeader documentation:
So, whenever
$storage.setCookie()is called on SSR side, it replaces all cookies which were set before and it's impossible to set 2 different cookies using$storage.setCookie()on SSR, as only the last one will get into "Set-Cookies" header.This PR aims to fix this issue.