Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @konveyor/lib-ui with @migtools/lib-ui #1471

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Aug 24, 2022

The @konveyor/lib-ui package has been migrated from the konveyor org to the migtools org as part of Konveyor being donated to the CNCF Sandbox. The npm package has been renamed to @migtools/lib-ui starting with the 8.4.1 release (see migtools/lib-ui#111).

Upgrading lib-ui from 5.1.2 -> 8.4.1 involves the following breaking changes:

  • From 6.0.0:
    • useformstate: Forms that rely on !field.isValid to show errors will now show validation errors on all required fields as soon as the form first renders. Consumers should replace the !field.isValid condition with field.shouldShowError or !field.isValid && field.isTouched.
  • From 7.0.0:
    • ValidatedTextInput: Any direct calls to getTextInputProps or getFormGroupProps that were passing a boolean for greenWhenValid will now need to instead pass an options object including greenWhenValid as a property.
  • From 8.0.0:
    • useFormState: Any forms using the yupOptions argument will need to wrap it in an object with the property yupOptions instead of passing it directly as a top-level argument.

None of these changes affect this repo because it is not using useFormState or ValidatedTextInput, so renaming imports is the only source change necessary here.

See also:

@mturley mturley requested review from a team and ibolton336 August 24, 2022 19:42
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Collaborator Author

mturley commented Aug 24, 2022

Edit: actually, realizing the other change in this upgrade was a bump in the PatternFly versions used as peer dependencies in lib-ui. Marking this as a draft, may not return to it considering the status of mig-ui.

@mturley mturley marked this pull request as draft August 24, 2022 20:00
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant