Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @konveyor/lib-ui with @migtools/lib-ui and upgrade peer dependencies #375

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Aug 24, 2022

The @konveyor/lib-ui package has been migrated from the konveyor org to the migtools org as part of Konveyor being donated to the CNCF Sandbox. The npm package has been renamed to @migtools/lib-ui starting with the 8.4.1 release (see migtools/lib-ui#111).

Upgrading lib-ui from 5.1.2 -> 8.4.1 involves the following breaking changes:

  • lib-ui's peer dependencies have changed:
    "peerDependencies": {
      "@patternfly/react-core": "^4.221.3",
      "@patternfly/react-tokens": "^4.73.3",
      "axios": "^0.21.2",
      "react": "^17.0.1",
      "react-dom": "^17.0.1"
    },
    • This PR upgrades the PatternFly packages to latest, and axios to 0.21.2.
  • From 6.0.0:
    • useformstate: Forms that rely on !field.isValid to show errors will now show validation errors on all required fields as soon as the form first renders. Consumers should replace the !field.isValid condition with field.shouldShowError or !field.isValid && field.isTouched.
  • From 7.0.0:
    • ValidatedTextInput: Any direct calls to getTextInputProps or getFormGroupProps that were passing a boolean for greenWhenValid will now need to instead pass an options object including greenWhenValid as a property.
  • From 8.0.0:
    • useFormState: Any forms using the yupOptions argument will need to wrap it in an object with the property yupOptions instead of passing it directly as a top-level argument.

Aside from peer dependency versions (none of which had breaking changes), none of these changes affect this repo because it is not using useFormState or ValidatedTextInput. Renaming imports is the only source change necessary here.

See also:

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you Mike!

@mturley mturley merged commit 8200ef8 into konveyor:main Sep 2, 2022
@mturley mturley deleted the migtools-lib-ui branch September 2, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants