-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/nix writer #253
base: master
Are you sure you want to change the base?
feat/nix writer #253
Conversation
9c1f4d0
to
bf36299
Compare
I'm OK with adding more information to |
Absolutely! That's great news about the possibility to extend the RichResult. Other than that, I have no real intention to upstream a nix-specific functionality, but it's a great way to figure out the API. This still relies on a layer violation, to urlquoteplus vslues that come from I'll separate the RichResult enhancemsnts into a separate PR, and then iterate further. 👍 |
bf36299
to
5d4b6a1
Compare
nvchecker/core.py
Outdated
@@ -486,7 +486,7 @@ def check_version_update( | |||
url = r.url, | |||
) | |||
else: | |||
logger.debug('up-to-date', name=r.name, version=r.version, url=r.url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended to make updated items standout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see! In my use case scenario, it's the rule to only update a single item, hence users where suggesting to actually show something, because otherwise there wouldn't be any output, at all.
If not a single item is picked for update, this is less of a problem and it becomes clear that something had happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I didn't expect only one item is checked except for debugging. nvchecker was written with the goal to quickly check updates for thousands of items.
Maybe we can provide up-to-date feedback when --entry
is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I'll implement this! That makes a lot more sense!
5ab8216
to
30ecccf
Compare
08dc3fa
to
b63c638
Compare
6864e5f
to
7a600d7
Compare
7a600d7
to
5d3abd5
Compare
This is a WIP patch implementing a nix writer.
I'd like to hear feedback on if we could come up with a suitable extension point that would allow maintaining this out of tree (as a plugin, maybe).